Re: [PATCH] R build system and CRAN importer (updated)

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> From 1c726be7746021f5d967d12154c057391e24585d Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 24 Jul 2015 16:49:57 +0200
>> Subject: [PATCH 1/2] import: Add 'cran' importer.
>>
>> * guix/import/cran.scm: New file.
>> * guix/scripts/import.scm: Add "cran" to 'importers'.
>> * guix/scripts/import/cran.scm: New file.
>> * tests/cran.scm: New file.
>> * Makefile.am (MODULES): Add 'guix/import/cran.scm' and
>>   'guix/scripts/import/cran.scm'.
>>   (SCM_TESTS): Add 'tests/cran.scm'.
>> * doc/guix.texi (Invoking guix import): Document it.
>> * po/guix/POTFILES.in: Add 'guix/scripts/import/cran.scm'.

[...]

> Otherwise LGTM.  OK to push with these changes.

Pushed with all suggested changes.

>> From 8271e8a5e7d237693e8d4b7b34e4a484b9a1fc22 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Fri, 31 Jul 2015 14:47:34 +0200
>> Subject: [PATCH 2/2] build: Add R build system.
>>
>> * guix/build-system/r.scm: New file.
>> * guix/build/r-build-system: New file.
>> * Makefile.am (MODULES): Add new files.
>> * doc/guix.texi (Build Systems): Document r-build-system.
>
> [...]
>
>> +(define (call-r command params)
>
> Nitpick: I’d call it ‘invoke-r’ (a function is called, a program is
> invoked.)

Changed to ‘invoke-r’ and pushed.

Thanks!

~~ Ricardo