From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 10/10] gnu: Add git-annex-remote-hubic.
Date: Fri, 4 Dec 2015 10:57:27 +0100
Message-ID: <idjwpsu8rjs.fsf@bimsb-sys02.mdc-berlin.net>
References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il>
	<1449153811-32039-11-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n7X-0007ex-8G
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:57:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n7S-0005ca-4R
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:57:43 -0500
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:37193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n7R-0005br-U7
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:57:38 -0500
In-Reply-To: <1449153811-32039-11-git-send-email-efraim@flashner.co.il>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org


Efraim Flashner <efraim@flashner.co.il> writes:

> +(define-public git-annex-remote-hubic
> +  (package
> +    (name "git-annex-remote-hubic")
> +    (version "0.3.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/Schnouki/" name "/archive/v"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version))

You should also append =E2=80=9C.tar.gz=E2=80=9D.

> +              (sha256
> +               (base32
> +                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"=
))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +    `(("python2-setuptools" ,python2-setuptools)
> +      ;; some extras for the tests
> +      ("python2-futures" ,python2-futures)
> +      ("python2-six" ,python2-six)))
> +    (inputs
> +     `(("python2-dateutil" ,python2-dateutil)
> +       ("python2-rauth" ,python2-rauth)
> +       ("python2-swiftclient" ,python2-swiftclient)))

These are probably propagated-inputs.

> +    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
> +    (synopsis "Use hubic as a git-annex remote")

I don=E2=80=99t know what =E2=80=9Chubic=E2=80=9D is but in the descripti=
on you spell it as
=E2=80=9ChubiC=E2=80=9D.  Which spelling is correct?

> +    (description
> +     "Git annex remote hubic allows you to use your hubiC account as a=
 \"special
> +repository\".")

I found it difficult to read this description because the first four
words are actually the name of the package.  In this case I=E2=80=99d sug=
gest
replacing =E2=80=9CGit annex remote hubic=E2=80=9D with the generic =E2=80=
=9CThis package=E2=80=9D; but
then you should also add =E2=80=9Cwith git-annex=E2=80=9D after =E2=80=9C=
special repository=E2=80=9D.

~~ Ricardo