From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add p7zip.
Date: Fri, 2 Sep 2016 14:12:05 +0200 [thread overview]
Message-ID: <idjwpiuh562.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <5C1179FB-7092-481F-A778-841ED20606CA@flashner.co.il>
Efraim Flashner <efraim@flashner.co.il> writes:
> On September 2, 2016 2:51:03 PM GMT+03:00, Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>>
>>Efraim Flashner <efraim@flashner.co.il> writes:
>>
>>> On Thu, Sep 01, 2016 at 03:05:34PM -0400, Kei Kebreau wrote:
>>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>>
>>>> > Kei Kebreau <kei@openmailbox.org> writes:
>>>> >
>>>> >> Ricardo Wurmus <rekado@elephly.net> writes:
>>>> >>
>>>> >>> Kei Kebreau <kei@openmailbox.org> writes:
>>>> >>>
>>>> >>>> Whoops, last patch was a bit messy and stacked on the previous
>>one. This
>>>> >>>> patch should be better!
>>>> >>>
>>>> >>> I just wanted to push a slightly modified version of this
>>(attached) but
>>>> >>> I cannot actually build the package. The patch to remove unused
>>code
>>>> >>> does not apply due to different line endings.
>>>> >>>
>>>> >>> Could you please take a look at this again and make sure that
>>the patch
>>>> >>> to the sources applies?
>>>> >>>
>>>> >>> ~~ Ricardo
>>>> >>>
>>>> >> I just tried it on my machine, and everything applied and built
>>>> >> correctly from a clean Guix tree. I don't exactly know how to
>>proceed
>>>> >> From here. Perhaps a third party can try to build from the patch?
>>>> >
>>>> > The problem might be with the inline patch in the email. Don’t
>>know.
>>>> >
>>>> > ~~ Ricardo
>>>>
>>>> I'll try sending it again, for lack of a better plan. If all else
>>fails
>>>> I can post it on paste.lisp.org.
>>
>>> Hunk #1 FAILED at 139 (different line endings).
>>[...]
>>> Hunk #1 FAILED at 47 (different line endings).
>>
>>These are the exact same errors I got. Maybe the line endings were
>>converted automatically when you saved the patch with your editor?
>>
>>~~ Ricardo
>
> I opened the mail with mutt, passed the patch to "cd workspace/guix; git am", which is my normal workflow
Sorry, my reply was meant to be directed at Kei.
~~ Ricardo
next prev parent reply other threads:[~2016-09-02 12:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 0:52 [PATCH] gnu: Add p7zip Kei Kebreau
2016-08-02 7:06 ` Ricardo Wurmus
2016-08-02 15:54 ` Kei Kebreau
2016-08-04 2:45 ` Kei Kebreau
2016-08-02 18:38 ` Eric Bavier
2016-08-08 19:58 ` Leo Famulari
2016-08-09 8:05 ` Ricardo Wurmus
2016-08-09 16:15 ` kei
2016-08-09 19:16 ` Ricardo Wurmus
2016-08-09 20:06 ` Kei Kebreau
2016-08-09 20:33 ` Ricardo Wurmus
2016-08-12 19:29 ` Kei Kebreau
2016-08-22 11:06 ` Ricardo Wurmus
2016-08-22 23:58 ` Kei Kebreau
2016-08-27 10:36 ` Kei Kebreau
2016-08-31 20:45 ` Ricardo Wurmus
2016-09-01 15:57 ` Kei Kebreau
2016-09-01 18:29 ` Ricardo Wurmus
2016-09-01 19:05 ` Kei Kebreau
2016-09-02 8:26 ` Efraim Flashner
2016-09-02 11:51 ` Ricardo Wurmus
2016-09-02 12:06 ` Efraim Flashner
2016-09-02 12:12 ` Ricardo Wurmus [this message]
2016-09-02 13:49 ` Kei Kebreau
2016-09-04 14:31 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjwpiuh562.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.