From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add samtools
Date: Mon, 15 Dec 2014 12:36:10 +0100 [thread overview]
Message-ID: <idjvbldjgb9.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87zjarqy5n.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
>>>> Can we disable the test suite for certain architectures? Or would they
>>>> have to be disabled completely?
>>
>> Since it fails the same way on mips64el, I suggest this instead:
>>
>> #:tests? (string=? (or (%current-system) (%current-target-system))
>> "x86_64-linux")
>
> Oops, we forgot to mention that there should be a comma before that
> first open paren, like this:
>
> #:tests? ,(string=? (or (%current-system) (%current-target-system))
> "x86_64-linux")
Attached is a patch that disables the tests on all systems but
x86_64-linux. I'm unsure about the indentation, though. Should the
compared string really be aligned with the arguments of `(or' (as shown
above), or rather aligned with `(or', the argument to `(string=?' (as in
the attached patch)?
-- rekado
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-samtools-disable-tests-for-non-64-bit-systems.patch --]
[-- Type: text/x-patch, Size: 1497 bytes --]
From c9846248c28f2c22660c156d4275326fe8afac80 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 15 Dec 2014 12:23:01 +0100
Subject: [PATCH] gnu: samtools: disable tests for non-64-bit systems
* gnu/packages/bioinformatics.scm (samtools): disable tests for all non-64-bit
systems because of an upstream bug in the test data.
---
gnu/packages/bioinformatics.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index bcc5d43..1f323eb 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -111,7 +111,14 @@ BED, GFF/GTF, VCF.")
"1y5p2hs4gif891b4ik20275a8xf3qrr1zh9wpysp4g8m0g1jckf2"))))
(build-system gnu-build-system)
(arguments
- '(#:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
+ `(;; There are 87 test failures when building on non-64-bit architectures
+ ;; due to invalid test data. This has since been fixed upstream (see
+ ;; <https://github.com/samtools/samtools/pull/307>), but as there has
+ ;; not been a new release we disable the tests for all non-64-bit
+ ;; systems.
+ #:tests? ,(string=? (or (%current-system) (%current-target-system))
+ "x86_64-linux")
+ #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
#:phases
(alist-cons-after
'unpack
--
1.9.3
next prev parent reply other threads:[~2014-12-15 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 14:48 [PATCH] gnu: Add samtools Ricardo Wurmus
2014-12-11 17:57 ` Ludovic Courtès
2014-12-12 9:48 ` Ricardo Wurmus
2014-12-12 22:55 ` Ludovic Courtès
2014-12-13 6:30 ` Mark H Weaver
2014-12-13 8:19 ` Ricardo Wurmus
2014-12-13 15:53 ` Ludovic Courtès
2014-12-13 16:30 ` Mark H Weaver
2014-12-13 17:04 ` Mark H Weaver
2014-12-15 11:36 ` Ricardo Wurmus [this message]
2014-12-15 22:12 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjvbldjgb9.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.