From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH]: Add CUPS.
Date: Mon, 5 Jan 2015 17:48:27 +0100
Message-ID: <idjvbklyy04.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjy4phz8e3.fsf@bimsb-sys02.mdc-berlin.net>
	<874ms5qlya.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Y8Apf-00046t-4c
	for guix-devel@gnu.org; Mon, 05 Jan 2015 11:48:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Y8ApW-0001Rd-J0
	for guix-devel@gnu.org; Mon, 05 Jan 2015 11:48:43 -0500
In-Reply-To: <874ms5qlya.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> There are a couple of problems with this package, one of which is that
>> the test suite is failing for some reason.  I have not been able to
>> figure out why the "cupsFileFind" test fails, so I disabled the tests.
>
> OK.  Do you have any more details from the test suite log?

I looked at this again and suddenly figured out what went wrong
(hardcoded search path for "cat" in a call to "cupsFileFind").  The
tests take a good while longer now and there are seven more failures
that I will work on before resubmitting an updated patch.

> The reason for splitting would be if it turns out that the include
> directory takes a fair amount of space that is not needed in many
> cases.  If that=E2=80=99s the case, then splitting makes sense.  That m=
ay well
> be the case: what=E2=80=99s the side of each of these outputs?

I see that splitting would not be required in this case; the outputs are
very small (6+MB for "out" and 240+kB for "include").

>> +    (license license:gpl2+)))
>
> Isn=E2=80=99t it GPLv2-only?

You are right (I was so sure I checked this).  I'll fix this in the
updated patch.

Best,
Ricardo