[PATCH] gnu: Add inklingreader

[PATCH] gnu: Add inklingreader

[Roel Janssen]

[-- Attachment #1: 0001-gnu-Add-inklingreader.patch --]
[-- Type: text/x-patch, Size: 3592 bytes --]

From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 10 Nov 2015 15:01:33 +0100
Subject: [PATCH] gnu: Add inklingreader

* gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
* gnu/packages/inklingreader.scm: The package description.
---
 gnu-system.am                  |  1 +
 gnu/packages/inklingreader.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 gnu/packages/inklingreader.scm

diff --git a/gnu-system.am b/gnu-system.am
index f3ded69..f8b3d42 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -158,6 +158,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/image.scm			\
   gnu/packages/imagemagick.scm			\
   gnu/packages/indent.scm			\
+  gnu/packages/inklingreader.scm		\
   gnu/packages/inkscape.scm			\
   gnu/packages/irssi.scm			\
   gnu/packages/iso-codes.scm			\
diff --git a/gnu/packages/inklingreader.scm b/gnu/packages/inklingreader.scm
new file mode 100644
index 0000000..a3aa471
--- /dev/null
+++ b/gnu/packages/inklingreader.scm
@@ -0,0 +1,65 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Roel Janssen <roel@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages inklingreader)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages texinfo))
+
+(define-public inklingreader
+  (package
+    (name "inklingreader")
+    (version "0.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
+    (build-system gnu-build-system)
+    (arguments `(#:configure-flags '("--enable-silent-rules")))
+    (inputs
+     `(("glib" ,glib)
+       ("cairo" ,cairo)
+       ("librsvg" ,librsvg)
+       ("gtk+" ,gtk+)
+       ("libusb" ,libusb)
+
+       ;; Needed to build the package.
+       ("texinfo" ,texinfo)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+
+    (home-page "http://savannah.gnu.org/projects/inklingreader/")
+    (synopsis "Wacom Inkling sketch format conversion and manipulation")
+    (description
+     "GNU InklingReader is a free software package to support the Wacom Inkling
+device, including data conversion to various free formats, basic editing
+features, and an Inkscape plugin.")
+    (license license:gpl3+)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 195 bytes --]

Dear list,

I've written a package description for my GNU package: InklingReader.
This is my first patch, so if I should've done something differently,
please let me know. 

Thanks,
Roel Janssen

Re: [PATCH] gnu: Add inklingreader

[Ricardo Wurmus]

Hi Roel,

thanks for the patch!

I wonder if the inklingreader could be added to an existing module.
Maybe ‘graphics.scm’?

> From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 10 Nov 2015 15:01:33 +0100
> Subject: [PATCH] gnu: Add inklingreader

Nitpick: end the summary line with a period ‘.’.

> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
> * gnu/packages/inklingreader.scm: The package description.

Normally, we write it like this:

> * gnu/packages/inklingreader.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

If adding to an existing module it would be something like this:

> * gnu/packages/graphics.scm (inklingreader): New variable.

[...]

> +(define-public inklingreader
> +  (package
> +    (name "inklingreader")
> +    (version "0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
> +                    version ".tar.gz"))

You should be able to use “mirror://gnu/” here.  I don’t know the exact
URL, though (and I haven’t tried yet).

> +              (sha256
> +               (base32
> +                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:configure-flags '("--enable-silent-rules")))

What does this do?  (I’m just curious.)

> +    (inputs
> +     `(("glib" ,glib)
> +       ("cairo" ,cairo)
> +       ("librsvg" ,librsvg)
> +       ("gtk+" ,gtk+)
> +       ("libusb" ,libusb)
> +
> +       ;; Needed to build the package.
> +       ("texinfo" ,texinfo)))

Inputs that are only needed at build time should be added to
‘native-inputs’ instead.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +

Please do not put an empty line here.

> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
> +    (description
> +     "GNU InklingReader is a free software package to support the Wacom Inkling
> +device, including data conversion to various free formats, basic editing
> +features, and an Inkscape plugin.")

Since all software in Guix is free software you should not mention this
here again.

I wonder about the Inkscape plugin: does it work out of the box with our
inkscape package?

> +    (license license:gpl3+)))

A very nice first contribution!  Thank you again.
(I’ll let others comment on this.)

~~ Ricardo

Re: [PATCH] gnu: Add inklingreader

[Mathieu Lirzin]

Hi,

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
>> +    (description
>> +     "GNU InklingReader is a free software package to support the Wacom Inkling
>> +device, including data conversion to various free formats, basic editing
>> +features, and an Inkscape plugin.")
>
> Since all software in Guix is free software you should not mention this
> here again.

In fact the description is in gnumaint:

  http://cvs.savannah.gnu.org/viewvc/womb/gnumaint/pkgblurbs.txt?revision=1.61&view=markup

If it gets fixed in Guix it will need to be fixed there too, or ‘guix
lint’ will continue to report a suggested description.

--
Mathieu Lirzin

Re: [PATCH] gnu: Add inklingreader

[Roel Janssen]

>>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>>> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
>>> +    (description
>>> +     "GNU InklingReader is a free software package to support the Wacom Inkling
>>> +device, including data conversion to various free formats, basic editing
>>> +features, and an Inkscape plugin.")
>>
>> Since all software in Guix is free software you should not mention this
>> here again.
>
> In fact the description is in gnumaint:
>
>   http://cvs.savannah.gnu.org/viewvc/womb/gnumaint/pkgblurbs.txt?revision=1.61&view=markup
>
> If it gets fixed in Guix it will need to be fixed there too, or ‘guix
> lint’ will continue to report a suggested description.

I don't know how to fix it in gnumaint.. I can update the package
description on the Guix file of course.

Re: [PATCH] gnu: Add inklingreader

[Mathieu Lirzin]

Roel Janssen <roel@gnu.org> writes:

>>>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>>>> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
>>>> +    (description
>>>> +     "GNU InklingReader is a free software package to support the Wacom Inkling
>>>> +device, including data conversion to various free formats, basic editing
>>>> +features, and an Inkscape plugin.")
>>>
>>> Since all software in Guix is free software you should not mention this
>>> here again.
>>
>> In fact the description is in gnumaint:
>>
>>   http://cvs.savannah.gnu.org/viewvc/womb/gnumaint/pkgblurbs.txt?revision=1.61&view=markup
>>
>> If it gets fixed in Guix it will need to be fixed there too, or ‘guix
>> lint’ will continue to report a suggested description.
>
> I don't know how to fix it in gnumaint.. I can update the package
> description on the Guix file of course.

this message was meant to Ricardo, sorry if it has confused you.  To
answer your question, in fact editing gnumaint requires commit access
that most of Guix contributors don't have.  We need to ask to Ludovic
for that. ;)

--
Mathieu Lirzin

Re: [PATCH] gnu: Add inklingreader

[Roel Janssen]

Hello Ricardo,

Thanks for your response.

> I wonder if the inklingreader could be added to an existing module.
> Maybe ‘graphics.scm’?

Well, InklingReader is a program with a GUI. Looking at 'graphics.scm'
seems to contain only libraries. The same seems to be true for
'image.scm'.

I'm fine with putting it in 'graphics.scm', but I don't think it belongs
there. (Correct me if I'm wrong, I'm new to Guix ;)

>> From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Tue, 10 Nov 2015 15:01:33 +0100
>> Subject: [PATCH] gnu: Add inklingreader
>
> Nitpick: end the summary line with a period ‘.’.

Sorry about that. Fixed in the second version.

>> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
>> * gnu/packages/inklingreader.scm: The package description.
>
> Normally, we write it like this:
>
>> * gnu/packages/inklingreader.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> If adding to an existing module it would be something like this:
>
>> * gnu/packages/graphics.scm (inklingreader): New variable.
>
> [...]

Sorry about that. This should be better in the second version.

>> +(define-public inklingreader
>> +  (package
>> +    (name "inklingreader")
>> +    (version "0.8")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
>> +                    version ".tar.gz"))
>
> You should be able to use “mirror://gnu/” here.  I don’t know the exact
> URL, though (and I haven’t tried yet).

I think this doesn't work for 'alpha.gnu.org' (at least 'guix lint'
crashes when using 'mirror://'). Other packages (like artanis) use
'ftp://alpha.gnu.org/...' as well.

If I am mistaking, please let me know what the URI should be.

>> +              (sha256
>> +               (base32
>> +                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
>> +    (build-system gnu-build-system)
>> +    (arguments `(#:configure-flags '("--enable-silent-rules")))
>
> What does this do?  (I’m just curious.)

It makes the compile command output shorter. Instead of displaying the
entire command ('gcc ...') it only displays the target name being
compiled.

I realise this may not be desired, so I removed it from the second
version. 

>> +    (inputs
>> +     `(("glib" ,glib)
>> +       ("cairo" ,cairo)
>> +       ("librsvg" ,librsvg)
>> +       ("gtk+" ,gtk+)
>> +       ("libusb" ,libusb)
>> +
>> +       ;; Needed to build the package.
>> +       ("texinfo" ,texinfo)))
>
> Inputs that are only needed at build time should be added to
> ‘native-inputs’ instead.

Thanks. I removed texinfo completely because the build process doesn't
build the documentation anyway. The inputs specified now are all runtime
dependencies.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +
>
> Please do not put an empty line here.

Fixed in the second version.

>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
>> +    (description
>> +     "GNU InklingReader is a free software package to support the Wacom Inkling
>> +device, including data conversion to various free formats, basic editing
>> +features, and an Inkscape plugin.")
>
> Since all software in Guix is free software you should not mention this
> here again.

Fixed in the second version.

> I wonder about the Inkscape plugin: does it work out of the box with our
> inkscape package?

It's separated from the program. To enable the Inkscape extension, one
has to copy files from the repository to
'~/.config/inkscape/extensions/' so that Inkscape can find it.

The files are not included in the release. Should I remove the mention
of the Inkscape plugin from the description?

Thanks for your time,
Roel Janssen

Re: [PATCH] gnu: Add inklingreader

[Mathieu Lirzin]

Hi Roel,

Roel Janssen <roel@gnu.org> writes:

>From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 10 Nov 2015 15:01:33 +0100
> Subject: [PATCH] gnu: Add inklingreader
>
> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
> * gnu/packages/inklingreader.scm: The package description.

Guix has somekind of "template" commit log when adding packages, you
will find multiple examples with

  git log --grep="(GNU_SYSTEM_MODULES): Add it"

When applying it to your package you will obtain this.

--8<---------------cut here---------------start------------->8---
gnu: Add inklingreader.

* gnu/packages/inklingreader.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
--8<---------------cut here---------------end--------------->8---

> ---
>  gnu-system.am                  |  1 +
>  gnu/packages/inklingreader.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 gnu/packages/inklingreader.scm
[...]
> +++ b/gnu/packages/inklingreader.scm
> @@ -0,0 +1,65 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Roel Janssen <roel@gnu.org>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages inklingreader)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gnome)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages libusb)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages texinfo))
> +
> +(define-public inklingreader
> +  (package
> +    (name "inklingreader")
> +    (version "0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:configure-flags '("--enable-silent-rules")))

this is automatically done, so this flag is not needed.

> +    (inputs
> +     `(("glib" ,glib)
> +       ("cairo" ,cairo)
> +       ("librsvg" ,librsvg)
> +       ("gtk+" ,gtk+)
> +       ("libusb" ,libusb)
> +
> +       ;; Needed to build the package.
> +       ("texinfo" ,texinfo)))

Actually the documentation is not built so I don't think this is needed.
If you want to easily provide the documentation to Guix you will need to
add the Automake variable "info_TEXINFOS" in you Makefile.am file in the
next release, see:

  https://www.gnu.org/software/automake/manual/automake.html#Texinfo

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +
> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")

I think It would be better to provide

  https://www.gnu.org/software/inklingreader/

> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
> +    (description
> +     "GNU InklingReader is a free software package to support the Wacom Inkling
> +device, including data conversion to various free formats, basic editing
> +features, and an Inkscape plugin.")
> +    (license license:gpl3+)))

Can you send an updated patch?

Thank you very much for your first package!

--
Mathieu Lirzin

Re: [PATCH] gnu: Add inklingreader

[Roel Janssen]

[-- Attachment #1: 0001-gnu-Add-inklingreader-v2.patch --]
[-- Type: text/x-patch, Size: 3374 bytes --]

From 1cda4dd832a4c654cca7eff150217305ba60573e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 10 Nov 2015 19:38:42 +0100
Subject: [PATCH] gnu: Add inklingreader.

* gnu/packages/inklingreader.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                  |  1 +
 gnu/packages/inklingreader.scm | 59 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 gnu/packages/inklingreader.scm

diff --git a/gnu-system.am b/gnu-system.am
index f3ded69..f8b3d42 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -158,6 +158,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/image.scm			\
   gnu/packages/imagemagick.scm			\
   gnu/packages/indent.scm			\
+  gnu/packages/inklingreader.scm		\
   gnu/packages/inkscape.scm			\
   gnu/packages/irssi.scm			\
   gnu/packages/iso-codes.scm			\
diff --git a/gnu/packages/inklingreader.scm b/gnu/packages/inklingreader.scm
new file mode 100644
index 0000000..5c1d2f6
--- /dev/null
+++ b/gnu/packages/inklingreader.scm
@@ -0,0 +1,59 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Roel Janssen <roel@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages inklingreader)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages pkg-config))
+
+(define-public inklingreader
+  (package
+    (name "inklingreader")
+    (version "0.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glib" ,glib)
+       ("cairo" ,cairo)
+       ("librsvg" ,librsvg)
+       ("gtk+" ,gtk+)
+       ("libusb" ,libusb)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://www.gnu.org/software/inklingreader/")
+    (synopsis "Wacom Inkling sketch format conversion and manipulation.")
+    (description
+     "GNU InklingReader is a package to support the Wacom Inkling device,
+including data conversion to various free formats, basic editing features,
+and an Inkscape plugin.")
+    (license license:gpl3+)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 2199 bytes --]

Hi Mathieu,

Thanks for your reply.

Mathieu Lirzin writes:

>>From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Tue, 10 Nov 2015 15:01:33 +0100
>> Subject: [PATCH] gnu: Add inklingreader
>>
>> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
>> * gnu/packages/inklingreader.scm: The package description.
>
> Guix has somekind of "template" commit log when adding packages, you
> will find multiple examples with
>
>   git log --grep="(GNU_SYSTEM_MODULES): Add it"
>
> When applying it to your package you will obtain this.
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add inklingreader.
>
> * gnu/packages/inklingreader.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---

Fixed.

>> ---
>>  gnu-system.am                  |  1 +
>>  gnu/packages/inklingreader.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 66 insertions(+)
>>  create mode 100644 gnu/packages/inklingreader.scm
> [...]
>> +++ b/gnu/packages/inklingreader.scm
>> @@ -0,0 +1,65 @@
>> [...]
>> +    (arguments `(#:configure-flags '("--enable-silent-rules")))
>
> this is automatically done, so this flag is not needed.

Fixed.

>> +    (inputs
>> +     `(("glib" ,glib)
>> +       ("cairo" ,cairo)
>> +       ("librsvg" ,librsvg)
>> +       ("gtk+" ,gtk+)
>> +       ("libusb" ,libusb)
>> +
>> +       ;; Needed to build the package.
>> +       ("texinfo" ,texinfo)))
>
> Actually the documentation is not built so I don't think this is needed.
> If you want to easily provide the documentation to Guix you will need to
> add the Automake variable "info_TEXINFOS" in you Makefile.am file in the
> next release, see:
>
>   https://www.gnu.org/software/automake/manual/automake.html#Texinfo

Fixed.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +
>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>
> I think It would be better to provide
>
>   https://www.gnu.org/software/inklingreader/

Fixed.

> Can you send an updated patch?

I attached it.

Thanks for your time,
Roel Janssen

Re: [PATCH] gnu: Add inklingreader

[Mathieu Lirzin]

Roel Janssen <roel@gnu.org> writes:

>>> From: Roel Janssen <roel@gnu.org>
>>> Date: Tue, 10 Nov 2015 15:01:33 +0100
>>> Subject: [PATCH] gnu: Add inklingreader
>>>
>>> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
>>> * gnu/packages/inklingreader.scm: The package description.
>>> ---
>>>  gnu-system.am                  |  1 +
>>>  gnu/packages/inklingreader.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 66 insertions(+)
>>>  create mode 100644 gnu/packages/inklingreader.

Pushed in 2f1531f008665496f144a39544980b2f07713174.

Thanks again for your first package.  I hope you will be able to make
your internship working on Guix!

Ludo: Can you push the updated description in gnumaint?

--
Mathieu Lirzin

Re: [PATCH] gnu: Add inklingreader

[Ludovic Courtès]

Mathieu Lirzin <mthl@gnu.org> skribis:

> Ludo: Can you push the updated description in gnumaint?

Done.

Thanks to both of you!

Ludo’.