From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add xz-java.
Date: Tue, 26 Apr 2016 16:53:26 +0200
Message-ID: <idjvb34776h.fsf@bimsb-sys02.mdc-berlin.net>
References: <87y48yxrew.fsf@gnu.org>
	<idjd1q98y2l.fsf@bimsb-sys02.mdc-berlin.net>
	<87wpoh1sfz.fsf@gnu.org>
	<idj7fgh8pma.fsf@bimsb-sys02.mdc-berlin.net>
	<874mbhd05y.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1av4Mv-0007Yt-Nb
	for guix-devel@gnu.org; Tue, 26 Apr 2016 10:53:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1av4Ms-0005Hi-Hb
	for guix-devel@gnu.org; Tue, 26 Apr 2016 10:53:41 -0400
In-Reply-To: <874mbhd05y.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Hi Roel,

> Ricardo Wurmus writes:
>
>> Roel Janssen <roel@gnu.org> writes:
>>
>>> One minor detail is the filename of the jar.  I renamed it to
>>> "xz-1.5.jar", which I think is the "standard" file naming scheme for =
our
>>> Java packages.
>>
>> I think it=E2=80=99s a bit ugly because we have the version number in =
the target
>> directory already, but I realise that this is how the jar is originall=
y
>> named, so I think that=E2=80=99s okay.
>
> The jar is originally named "xz.jar".  I thought other Java packages
> included the version number in the filename, so I just followed this
> practice.
>
> Either "xz.jar" or "xz-1.5.jar" is fine with me.
>
>> However, we should not hardcode the version string.  Instead we should
>> do something like this (untested):
>>
>>     #:jar-name ,(string-append "xz-" version ".jar")
>>
>> What do you think?  If this works for you I=E2=80=99ll commit your pat=
ch with
>> this change.
>
> I've just tested it and it works.  Since you're better at making a
> stylistic decision, I want to leave it up to you whether you want to
> append the version number or not.  Both ways are fine with me.

I forgot to reply to this message and I no longer remember what we
should do.  Do you have an updated patch for =E2=80=9Cjava-xz=E2=80=9D (w=
ith or without
version number)?

~~ Ricardo