From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add rpy2.
Date: Mon, 20 Jul 2015 11:51:46 +0200
Message-ID: <idjtwsz2m31.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjoajogoxz.fsf@bimsb-sys02.mdc-berlin.net>
	<87oajmkds9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZH7lN-000271-Sx
	for guix-devel@gnu.org; Mon, 20 Jul 2015 05:53:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZH7lJ-0002zI-Re
	for guix-devel@gnu.org; Mon, 20 Jul 2015 05:53:33 -0400
In-Reply-To: <87oajmkds9.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> From 070b4f5553ae30c05b97a67692b54503c73ca42f Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Tue, 7 Jul 2015 13:56:49 +0200
>> Subject: [PATCH] gnu: Add python-rpy2.
>>
>> * gnu/packages/python.scm (python-rpy2, python2-rpy2): New variables.
>
> [...]
>
>> +    (inputs
>> +     `(("python-six" ,python-six)
>> +       ("readline" ,readline)
>> +       ("icu4c" ,icu4c)
>> +       ("pcre" ,pcre)))
>> +    (native-inputs
>> +     `(("python-setuptools" ,python-setuptools)
>> +       ("r" ,r)))
>
> I think R is used for its libraries, so it should be in =E2=80=98inputs=
=E2=80=99 in
> theory.
>
>> +    (license gpl2+)))
>
> R being GPLv3+, this should be the same.
>
> OK with these changes!

Thanks for the review.  I pushed it with the suggested changes.

~~ Ricardo