From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 0/2] Fix IBus input methods. Date: Fri, 2 Sep 2016 16:19:24 +0200 Message-ID: References: <20160824220937.8745-1-rekado@elephly.net> <87k2f5cdkz.fsf@member.fsf.org> <87zio1njzj.fsf@elephly.net> <87inuejvdr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfpJj-0007Qm-85 for guix-devel@gnu.org; Fri, 02 Sep 2016 10:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfpJe-0005o7-Sf for guix-devel@gnu.org; Fri, 02 Sep 2016 10:19:38 -0400 In-Reply-To: <87inuejvdr.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> =E5=AE=8B=E6=96=87=E6=AD=A6 writes: >> >>> Ricardo Wurmus writes: >>> >>>> gnu: gtk+-2: Add patch to support GUIX_GTK2_IM_MODULE_FILE. >>>> gnu: gtk+: Add patch to support GUIX_GTK3_IM_MODULE_FILE. >>> >>> Look good to me! >> >> Thanks! >> >> What do you think: should this be a separate branch (e.g. =E2=80=9Cgtk= -rebuild=E2=80=9D) >> or should it be pushed to =E2=80=9Ccore-updates=E2=80=9D? > > As discussed on IRC, I=E2=80=99ve added a =E2=80=9Cjobset=E2=80=9D: > > https://hydra.gnu.org/jobset/gnu/gtk-im-modules > > There seems to be only 1 new failure compared to =E2=80=98master=E2=80=99= : > > https://hydra.gnu.org/eval/109124?compare=3Dmaster#tabs-now-fail > > Could you take a look? This looks unrelated to me. The error is that =E2=80=9Ctests/autojump_utils_test.py=E2=80=9D cannot be opened in the =E2= =80=9Ccheck=E2=80=9D phase. That=E2=80=99s expected because the file is actually called =E2=80=9Ctests/unit/autojump_utils_test.py=E2=80=9D (note the =E2=80=9Cun= it=E2=80=9D directory). I=E2=80=99m convinced my patch to the GTKs couldn=E2=80=99t possibly have= caused this. Here are the relevant parts of the log: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ starting phase `unpack' [...] autojump-release-v22.3.4/tests/unit/ autojump-release-v22.3.4/tests/unit/__init__.py autojump-release-v22.3.4/tests/unit/autojump_match_test.py autojump-release-v22.3.4/tests/unit/autojump_utils_test.py [...] phase `unpack' succeeded after 0.1 seconds [...] starting phase `patch-source-shebangs' [...] patch-shebang: ./tests/unit/autojump_utils_test.py: changing `/usr/bin/en= v python' to `/gnu/store/wa1yc835mb7pmmrj45xfgviqr5fbasqq-python-wrapper-= 3.4.3/bin/python' patch-shebang: ./uninstall.py: changing `/usr/bin/env python' to `/gnu/st= ore/wa1yc835mb7pmmrj45xfgviqr5fbasqq-python-wrapper-3.4.3/bin/python' phase `patch-source-shebangs' succeeded after 0.1 seconds starting phase `patch-generated-file-shebangs' phase `patch-generated-file-shebangs' succeeded after 0.0 seconds starting phase `check' python: can't open file 'tests/autojump_utils_test.py': [Errno 2] No such= file or directory phase `check' failed after 1.8 seconds ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > We=E2=80=99ll have to merge =E2=80=98master=E2=80=99 into it and evalua= te it again. Can =E2=80=9Cgtk-im-modules=E2=80=9D not be merged into the master branch= directly? ~~ Ricardo