From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add bioawk.
Date: Wed, 9 Mar 2016 10:43:30 +0100
Message-ID: <idjsi00vvel.fsf@bimsb-sys02.mdc-berlin.net>
References: <87d1r4eno9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1adafl-0002JY-KN
	for guix-devel@gnu.org; Wed, 09 Mar 2016 04:44:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1adafg-0000si-KZ
	for guix-devel@gnu.org; Wed, 09 Mar 2016 04:44:53 -0500
In-Reply-To: <87d1r4eno9.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> Please let me know when something is wrong with the patch.

In addition to Leo=E2=80=99s comments here are mine:

> +    (arguments
> +     `(#:parallel-build? #f

Why is parallel-build disabled?  Could you add a comment?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)

We usually just do =E2=80=9C#:tests? #f=E2=80=9D with a comment, instead =
of deleting the
=E2=80=9Ccheck=E2=80=9D phase.

> +         (replace
> +          'install

Please put =E2=80=9C'install=E2=80=9D on the same line as =E2=80=9C(repla=
ce=E2=80=9D.

> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let ((bin (string-append (assoc-ref outputs "out") "/bin"=
)))
> +              (install-file "bioawk" bin)))))))
> +    (home-page "https://github.com/lh3/bioawk")
> +    (synopsis "AWK with bioinformatics extensions")
> +    (description "Bioawk is an extension to Brian Kernighan's awk, add=
ing the
> +support of several common biological data formats, including optionall=
y gzip'ed
> +BED, GFF, SAM, VCF, FASTA/Q and TAB-delimited formats with column name=
s.  It
> +also adds a few built-in functions and an command line option to use T=
AB as the

=E2=80=9Ca command-line option=E2=80=9D, not =E2=80=9Can=E2=80=9D

Thanks!

~~ Ricardo