From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH]: Add IcedTea 6
Date: Thu, 29 Jan 2015 10:47:17 +0100 [thread overview]
Message-ID: <idjr3ud7wbe.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <8761bqq3wn.fsf@gnu.org>
Ludovic Courtès writes:
>> I rewrote this to instead check the generated test logs in test/ for
>> lines starting with "Error:" or "FAILED:". To disable tests I wrapped
>> it in an (or #t ...) as the argument #:tests? #f does not disable a
>> custom check phase.
>>
>> 'check
>> (lambda _
>> ;; The "make check-*" targets always return zero, so we need to
>> ;; check for errors in the associated log files to determine
>> ;; whether any tests have failed.
>> (use-modules (ice-9 rdelim))
>> (let* ((error-pattern (make-regexp "^(Error|FAILED):.*"))
>> (checker (lambda (port)
>> (let loop ((_ #t))
>
> You can make it (let loop () ... (loop)).
Ah, right. Fixed.
> One last thing: perhaps we can directly remove mips64el-linux from
> ‘supported-platforms’?
Is it known to not build on mips64el?
> OK to push.
I pushed without disabling any platform yet. Based on the build results
I will update the package.
> Thanks,
> Ludo’.
Cheers,
Ricardo
next prev parent reply other threads:[~2015-01-29 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 15:33 [PATCH]: Add IcedTea 6 Ricardo Wurmus
2015-01-27 21:55 ` Ludovic Courtès
2015-01-28 15:47 ` Ricardo Wurmus
2015-01-28 16:13 ` Ludovic Courtès
2015-01-29 9:47 ` Ricardo Wurmus [this message]
2015-01-29 22:44 ` Andreas Enge
2015-02-15 12:52 ` Andreas Enge
2015-02-15 13:54 ` Ricardo Wurmus
2015-02-15 14:44 ` Andreas Enge
2015-02-15 15:57 ` Ricardo Wurmus
2015-02-15 16:05 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjr3ud7wbe.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.