From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH v1]: gnu: Add R.
Date: Mon, 16 Feb 2015 16:37:47 +0100
Message-ID: <idjpp99kgtw.fsf@bimsb-sys02.mdc-berlin.net>
References: <idj8ug2konl.fsf@bimsb-sys02.mdc-berlin.net>
	<87zj8hz9ai.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YNNkG-0008H9-UK
	for guix-devel@gnu.org; Mon, 16 Feb 2015 10:38:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YNNkC-0001Td-KB
	for guix-devel@gnu.org; Mon, 16 Feb 2015 10:38:00 -0500
In-Reply-To: <87zj8hz9ai.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> +    (inputs
>> +     `(("atlas" ,atlas) ; --with-blas
>> +       ("bzip2" ,bzip2)
>
> Unless used for libbz2, move it to =E2=80=98native-inputs=E2=80=99.
>
>> +       ("perl" ,perl)
>
> Likewise.
>
>> +       ("texlive" ,texlive) ; needed to make vignettes
>> +       ("texinfo" ,texinfo) ; for building HTML manuals
>> +       ("which" ,which) ; for tests/Examples/base-Ex.R
>
> These 3 are definitely native inputs.
>
>> +       ("xz" ,xz)
>
> Most likely native input.

I fixed the inputs vs native-inputs issues.  Sorry about that.

>> +    (home-page "http://www.r-project.org/")
>> +    (synopsis "Language and environment for statistical computing and=
 graphics")
>> +    (description
>> +     "R is a language and environment for statistical computing and g=
raphics.
>> +R is similar to the award-winning S system, which was developed at Be=
ll
>
> =E2=80=98guix lint=E2=80=99 should propose you a synopsis and descripti=
on; could you use
> them?
>
> The rest LGTM.

I've taken over the description and synopsis suggested by "guix lint"
and pushed the patch.

Thanks again for the review!

~~ Ricardo