[PATCH] Add ustr.

[PATCH] Add ustr.

[Ricardo Wurmus]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-ustr.patch --]
[-- Type: text/x-patch, Size: 2364 bytes --]

From 0caa764661bef61145541497a0124ff2c7e8494c Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Thu, 17 Mar 2016 13:08:30 +0100
Subject: [PATCH] gnu: Add ustr.

* gnu/packages/textutils.scm (ustr): New variable.
---
 gnu/packages/textutils.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 6f3782f..d2f7d32 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -185,6 +185,47 @@ the Hannon Lab.")
 input bits thoroughly but are not suitable for cryptography.")
       (license license:expat))))
 
+(define-public ustr
+  (package
+    (name "ustr")
+    (version "1.0.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.and.org/ustr/" version
+                                  "/ustr-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1i623ygdj7rkizj7985q9d6vj5amwg686aqb5j3ixpkqkyp6xbrx"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list "CC=gcc"
+             "HIDE="
+             "LDCONFIG=echo"
+             (string-append "prefix=" (assoc-ref %outputs "out"))
+             "all-shared")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'disable-check-for-stdint
+           (lambda _
+             ;; Of course we have stdint.h, just not in /usr/include
+             (substitute* '("Makefile"
+                            "ustr-import.in")
+               (("-f \"/usr/include/stdint.h\"") "-z \"\""))
+             #t))
+         ;; No configure script
+         (delete 'configure))))
+    (home-page "http://www.and.org/ustr/")
+    (synopsis "String library with very low memory overhead")
+    (description
+     "Ustr is a string library for C with very low memory overhead.")
+    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
+    ;; LGPL, etc. ... if you need another license to help compatibility, just
+    ;; ask for it.  It's basically public domain, without all the legal
+    ;; problems for everyone that trying to make something public domain
+    ;; entails."
+    (license license:public-domain)))
+
 (define-public libconfig
   (package
     (name "libconfig")
-- 
2.1.0

Re: [PATCH] Add ustr.

[Leo Famulari]

On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/textutils.scm (ustr): New variable.

[...]

> +              (uri (string-append "http://www.and.org/ustr/" version
> +                                  "/ustr-" version ".tar.bz2"))


Wow, that is a nice domain name!

It looks like this directory only contains the current version of the
code, but I can't find an archive of old releases. How about mentioning
this in a comment, and (maybe) asking and.org to provide an archive?

> +              (sha256
> +               (base32
> +                "1i623ygdj7rkizj7985q9d6vj5amwg686aqb5j3ixpkqkyp6xbrx"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc"
> +             "HIDE="

I read the Makefile's comment about this. ;)

> +             "LDCONFIG=echo"

Can you explain this one in a comment?

> +             (string-append "prefix=" (assoc-ref %outputs "out"))
> +             "all-shared")

[...]

> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
> +    ;; ask for it.  It's basically public domain, without all the legal
> +    ;; problems for everyone that trying to make something public domain
> +    ;; entails."
> +    (license license:public-domain)))

Sounds good to me. Hopefully there are no objections from the legal
experts!

Re: [PATCH] Add ustr.

[Ricardo Wurmus]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/textutils.scm (ustr): New variable.
>
> [...]
>
>> +              (uri (string-append "http://www.and.org/ustr/" version
>> +                                  "/ustr-" version ".tar.bz2"))

[...]

> It looks like this directory only contains the current version of the
> code, but I can't find an archive of old releases. How about mentioning
> this in a comment, and (maybe) asking and.org to provide an archive?

Actually, there are older versions as well.  Version 1.0.2, for example,
is at

    http://www.and.org/ustr/1.0.2/ustr-1.0.2.tar.bz2

>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:make-flags
>> +       (list "CC=gcc"
>> +             "HIDE="
>
> I read the Makefile's comment about this. ;)

I guess we don’t qualify as “all sane people” :)

>> +             "LDCONFIG=echo"
>
> Can you explain this one in a comment?

Will do.

>> +             (string-append "prefix=" (assoc-ref %outputs "out"))
>> +             "all-shared")
>
> [...]
>
>> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
>> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
>> +    ;; ask for it.  It's basically public domain, without all the legal
>> +    ;; problems for everyone that trying to make something public domain
>> +    ;; entails."
>> +    (license license:public-domain)))
>
> Sounds good to me. Hopefully there are no objections from the legal
> experts!

Thanks for taking the time to review!  I’ll push this after adding the
comment.

~~ Ricardo

Re: [PATCH] Add ustr.

[Leo Famulari]

On Mon, Mar 21, 2016 at 03:50:44PM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
> >> * gnu/packages/textutils.scm (ustr): New variable.
> >
> > [...]
> >
> >> +              (uri (string-append "http://www.and.org/ustr/" version
> >> +                                  "/ustr-" version ".tar.bz2"))
> 
> [...]
> 
> > It looks like this directory only contains the current version of the
> > code, but I can't find an archive of old releases. How about mentioning
> > this in a comment, and (maybe) asking and.org to provide an archive?
> 
> Actually, there are older versions as well.  Version 1.0.2, for example,
> is at
> 
>     http://www.and.org/ustr/1.0.2/ustr-1.0.2.tar.bz2

Ah, I see now!

> 
> >> +    (build-system gnu-build-system)
> >> +    (arguments
> >> +     `(#:make-flags
> >> +       (list "CC=gcc"
> >> +             "HIDE="
> >
> > I read the Makefile's comment about this. ;)
> 
> I guess we don’t qualify as “all sane people” :)
> 
> >> +             "LDCONFIG=echo"
> >
> > Can you explain this one in a comment?
> 
> Will do.
> 
> >> +             (string-append "prefix=" (assoc-ref %outputs "out"))
> >> +             "all-shared")
> >
> > [...]
> >
> >> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
> >> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
> >> +    ;; ask for it.  It's basically public domain, without all the legal
> >> +    ;; problems for everyone that trying to make something public domain
> >> +    ;; entails."
> >> +    (license license:public-domain)))
> >
> > Sounds good to me. Hopefully there are no objections from the legal
> > experts!
> 
> Thanks for taking the time to review!  I’ll push this after adding the
> comment.

Okay!

> 
> ~~ Ricardo