From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add ustr.
Date: Mon, 21 Mar 2016 15:50:44 +0100
Message-ID: <idjpounsx4r.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjshzpti8i.fsf@bimsb-sys02.mdc-berlin.net>
	<20160318184056.GA9682@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ai1AZ-0008WT-4r
	for guix-devel@gnu.org; Mon, 21 Mar 2016 10:51:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ai1AT-0001Xr-Qd
	for guix-devel@gnu.org; Mon, 21 Mar 2016 10:50:59 -0400
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:42025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ai1AT-0001Xf-HL
	for guix-devel@gnu.org; Mon, 21 Mar 2016 10:50:53 -0400
In-Reply-To: <20160318184056.GA9682@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>


Leo Famulari <leo@famulari.name> writes:

> On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/textutils.scm (ustr): New variable.
>
> [...]
>
>> +              (uri (string-append "http://www.and.org/ustr/" version
>> +                                  "/ustr-" version ".tar.bz2"))

[...]

> It looks like this directory only contains the current version of the
> code, but I can't find an archive of old releases. How about mentioning
> this in a comment, and (maybe) asking and.org to provide an archive?

Actually, there are older versions as well.  Version 1.0.2, for example,
is at

    http://www.and.org/ustr/1.0.2/ustr-1.0.2.tar.bz2

>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:make-flags
>> +       (list "CC=3Dgcc"
>> +             "HIDE=3D"
>
> I read the Makefile's comment about this. ;)

I guess we don=E2=80=99t qualify as =E2=80=9Call sane people=E2=80=9D :)

>> +             "LDCONFIG=3Decho"
>
> Can you explain this one in a comment?

Will do.

>> +             (string-append "prefix=3D" (assoc-ref %outputs "out"))
>> +             "all-shared")
>
> [...]
>
>> +    ;; Quoted from the home page: "The License for the code is MIT, n=
ew-BSD,
>> +    ;; LGPL, etc. ... if you need another license to help compatibili=
ty, just
>> +    ;; ask for it.  It's basically public domain, without all the leg=
al
>> +    ;; problems for everyone that trying to make something public dom=
ain
>> +    ;; entails."
>> +    (license license:public-domain)))
>
> Sounds good to me. Hopefully there are no objections from the legal
> experts!

Thanks for taking the time to review!  I=E2=80=99ll push this after addin=
g the
comment.

~~ Ricardo