From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH]: gnu: Add HISAT. Date: Thu, 12 Feb 2015 12:04:22 +0100 Message-ID: References: <87fvae8z7h.fsf@gnu.org> <20150211111501.GA5291@debian> <87mw4kt6kn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLrZQ-0002aH-UU for guix-devel@gnu.org; Thu, 12 Feb 2015 06:04:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLrZN-0001nh-Oi for guix-devel@gnu.org; Thu, 12 Feb 2015 06:04:32 -0500 In-Reply-To: <87mw4kt6kn.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> I wrote the author an email to ask whether this can be fixed upstream >> for other architectures than x86_64. Until then should I just declare >> x86_64 as the only supported architecture? > > Probably yes, with a comment pointing to this discussion and possibly > the one with the author(s). This may not even be necessary; the developer replied with a hint and attached is a patch that should fix the build on non-x86_64 architectures. It builds fine locally with ./pre-inst-env guix build --system=3Di686-linux hisat Does this look okay? ~~ Ricardo --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename="0001-gnu-hisat-fix-build-on-non-x86_64.patch" >From 5a73d260fcff839f5d07ef4ae684c78c4660f3d3 Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Thu, 12 Feb 2015 11:58:40 +0100 Subject: [PATCH] gnu: hisat: fix build on non-x86_64. * gnu/packages/bioinformatics.scm (hisat): Add "POPCNT_CAPABILITY=0" to make-flags on architectures other than x86_64. --- gnu/packages/bioinformatics.scm | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index 48bb9dd..f384cb8 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -252,8 +252,15 @@ Illumina, Roche 454, and the SOLiD platform.") "1k381ydranqxp09yf2y7w1d0chz5d59vb6jchi89hbb0prq19lk5")))) (build-system gnu-build-system) (arguments - '(#:tests? #f ;no check target - #:make-flags '("allall") + `(#:tests? #f ;no check target + #:make-flags '("allall" + ;; Disable unsupported `popcnt' instructions on + ;; architectures other than x86_64 + ,@(if (string-prefix? "x86_64" + (or (%current-target-system) + (%current-system))) + '() + '("POPCNT_CAPABILITY=0"))) #:phases (alist-replace 'unpack -- 2.1.0 --=-=-=--