From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add ruby-bio-logger.
Date: Wed, 16 Sep 2015 18:02:59 +0200
Message-ID: <idjoah273nw.fsf@bimsb-sys02.mdc-berlin.net>
References: <55f907bb.9/Upvwvparw1Ma9U%pjotr.public12@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZcFAx-0002U4-Da
	for guix-devel@gnu.org; Wed, 16 Sep 2015 12:03:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZcFAu-0005Kw-81
	for guix-devel@gnu.org; Wed, 16 Sep 2015 12:03:15 -0400
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:56521)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZcFAt-0005Jq-Uq
	for guix-devel@gnu.org; Wed, 16 Sep 2015 12:03:12 -0400
In-Reply-To: <55f907bb.9/Upvwvparw1Ma9U%pjotr.public12@thebird.nl>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel@gnu.org

Hi Pjotr,

> * gnu/packages/ruby.scm (ruby-bio-logger): New variable.

[...]
 =20
> +(define-public ruby-bio-logger
> +  (package
> +    (name "ruby-bio-logger")
> +    (version "1.0.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (rubygems-uri "bio-logger" version))
> +        (sha256
> +          (base32
> +            "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28"))))

This opening quote of this string should be aligned with the =E2=80=9Cb=E2=
=80=9D in
=E2=80=9Cbase64=E2=80=9D.  Likewise, the opening parenthesis of =E2=80=9C=
(base32 ...)=E2=80=9D should be
aligned with the =E2=80=9Cs=E2=80=9D in =E2=80=9C(sha256 ...)=E2=80=9D, a=
nd =E2=80=9C(origin=E2=80=9D should be aligned
with the =E2=80=9Cs=E2=80=9D of =E2=80=9C(source=E2=80=9D.

Are you using Emacs to indent?  In many cases you can just use =E2=80=98M=
-x
indent-sexp=E2=80=99.

> +    (build-system ruby-build-system)
> +    (propagated-inputs `(("ruby-log4r" ,ruby-log4r)))
> +    (arguments
> +     '(#:tests? #f)) ; no test suite
> +    (synopsis "Log4r wrapper for Ruby with extra features")
> +    (description "Library with extra logging features on top of
> +ruby-log4r (not specific to bioinformatics)")

This is not a complete description as it is not a full sentence.  A
minimal description might be

  =E2=80=9CBio-logger is a wrapper around Log4r adding extra logging feat=
ures
such as x, y, and z.=E2=80=9D

The README at the Github site is rather detailed; mentioning a few of
the added features in the description would be nice.

> +    (home-page "https://github.com/pjotrp/bioruby-logger-plugin")
> +    (license license:expat)))
> +
>  (define-public ruby-atoulme-antwrap
>    (package
>      (name "ruby-atoulme-antwrap")

~~ Ricardo