From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add IcedTea 7.
Date: Tue, 28 Apr 2015 12:10:32 +0200 [thread overview]
Message-ID: <idjmw1sef6v.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87y4libmyw.fsf@gnu.org>
Ludovic Courtès writes:
>> * gnu/packages/java.scm (icedtea7): New variable.
>
> [...]
>
>> + #:locale "C"
>
> Could you add a comment explaining why?
Done
>> + ,@(substitute-keyword-arguments `(#:modules ((guix build gnu-build-system)
>> + (guix build utils)
>> + (srfi srfi-1)
>> + (srfi srfi-26))
>> + ,@(package-arguments icedtea6))
>
> The ,@ should be aligned with #:modules (unfortunately Emacs fails to do
> that by default.)
I noticed that the #:modules stuff was not actually required, so it
looks nicer now.
>
>> + ((#:phases phases)
>> + `(alist-replace
>
> This is typically a case where ‘modify-phases’ would be more readable,
> if you feel like changing it.
I rewrote this to use the 'modify-phase' syntax and pushed to master.
Thank you for the review!
~~ Ricardo
prev parent reply other threads:[~2015-04-28 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 12:24 [PATCH] Add IcedTea 7 Ricardo Wurmus
2015-04-23 20:37 ` Ludovic Courtès
2015-04-28 10:10 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjmw1sef6v.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.