From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: cups: Update to 2.1.3 (was gnu: cups: Update to 2.1.3 - request for help patching Makefiles) Date: Thu, 3 Mar 2016 16:44:05 +0100 Message-ID: References: <20160220055736.GC9159@jasmine> <9415c297723d5ea0e4cc85fbbfd46b57@riseup.net> <64e80cbba672d68ca21844d997f93022@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abVQK-000688-TL for guix-devel@gnu.org; Thu, 03 Mar 2016 10:44:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abVQK-0003Yd-1C for guix-devel@gnu.org; Thu, 03 Mar 2016 10:44:20 -0500 In-Reply-To: <64e80cbba672d68ca21844d997f93022@riseup.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: swedebugia@riseup.net Cc: guix-devel , guix-devel-bounces+swedebugia=riseup.net@gnu.org swedebugia@riseup.net writes: >> I will focus on getting it to compile with the appropriate >> configure-flags and afterwards we can collaborate on creating a >> service for cups (with a config file). >>=20 >> Patching is necessary because we want cups to write logs and state/run >> files to /var/cups and when compiling it fails when trying to create >> those directories. > > I succeeded in getting it patched and compiling. :) Oh, good! Your patch doesn=E2=80=99t include the patch gnu/packages/patches/cups-dir.patch We also usually don=E2=80=99t put so many unrelated changes into the same commit. I see that your commit updates =E2=80=9Ccups-minimal=E2=80=9D, a= dds a patch, changes the configure-flags for =E2=80=9Ccups-minimal=E2=80=9D and =E2=80= =9Ccups=E2=80=9D(?) ... It would be better to split them into separate commits. > cupsd still refuses to run for the following reason: > sdb@unknown=20 > /gnu/store/gm397jmdp3jafz6gm5ry6c459dvapcf7-cups-minimal-2.1.3/sbin$=20 > sudo cupsd -t > "/gnu/store/qs3xymcsgxa68i8m188261rhxsszx7za-cups-2.1.0/etc/cups/cups-f= iles.conf"=20 > contains errors. Shouldn=E2=80=99t it read the configuration from =E2=80=9C/etc=E2=80=9D f= irst and only then look up its default configuration file in =E2=80=9C$out/etc/=E2=80=9D? It=E2=80= =99s weird that this unchanged file (or was it changed by the missing patch?) would be reported as containing errors. ~~ Ricardo