Re: [PATCH] gnu: cups: Update to 2.1.3 (was gnu: cups: Update to 2.1.3 - request for help patching Makefiles)

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

swedebugia@riseup.net writes:

>> I will focus on getting it to compile with the appropriate
>> configure-flags and afterwards we can collaborate on creating a
>> service for cups (with a config file).
>> 
>> Patching is necessary because we want cups to write logs and state/run
>> files to /var/cups and when compiling it fails when trying to create
>> those directories.
>
> I succeeded in getting it patched and compiling. :)

Oh, good!

Your patch doesn’t include the patch

    gnu/packages/patches/cups-dir.patch

We also usually don’t put so many unrelated changes into the same
commit.  I see that your commit updates “cups-minimal”, adds a patch,
changes the configure-flags for “cups-minimal” and “cups”(?) ... It
would be better to split them into separate commits.

> cupsd still refuses to run for the following reason:
> sdb@unknown 
> /gnu/store/gm397jmdp3jafz6gm5ry6c459dvapcf7-cups-minimal-2.1.3/sbin$ 
> sudo cupsd -t
> "/gnu/store/qs3xymcsgxa68i8m188261rhxsszx7za-cups-2.1.0/etc/cups/cups-files.conf" 
> contains errors.

Shouldn’t it read the configuration from “/etc” first and only then look
up its default configuration file in “$out/etc/”?  It’s weird that this
unchanged file (or was it changed by the missing patch?) would be
reported as containing errors.

~~ Ricardo