From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqqg-0005In-Uc
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:33:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqqc-0002Qb-2k
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:33:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39502)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fwqqb-0002QU-Uo
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fwqqb-0005on-RR
	for guix-patches@gnu.org; Mon, 03 Sep 2018 11:33:01 -0400
Subject: [bug#32586] [PATCH] gnu: Add r-svdialogs.
References: <20180830102502.10156-1-madalinionel.patrascu@mdc-berlin.de>
In-Reply-To: <20180830102502.10156-1-madalinionel.patrascu@mdc-berlin.de>
Resent-Message-ID: <handler.32586.B32586.153598877422351@debbugs.gnu.org>
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 3 Sep 2018 17:32:50 +0200
Message-ID: <idjmusy38bh.fsf@bimsb-sys02.mdc-berlin.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 32586@debbugs.gnu.org
Cc: pimi <madalinionel.patrasc@mdc-berlin.de>

Hi,

thanks for the patch!

> +
> +(define-public r-svdialogs
> +  (package
> +    (name "r-svdialogs")
> +    (version "1.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "svDialogs" version))
> +       (sha256
> +        (base32 "0xqppydfawnwk84kb5qiybwbcmv38vn4imgz01mz2pnq4xb80p97"))=
))
> +    (properties `((upstream-name . "svDialogs")))
> +    (build-system r-build-system)
> +    (inputs
> +     `(("yad" ,yad)

I see that you provide a patch for =E2=80=9Cyad=E2=80=9D in another issue. =
 In the
future please send a series of dependent patches together to the same
ticket address.  (Create a new ticket first by sending a =E2=80=9Ccover let=
ter=E2=80=9D
to guix-patches@gnu.org first.)

> +       ("zenity" ,zenity)))
> +    (propagated-inputs
> +     `(("r-rstudioapi" ,r-rstudioapi)
> +       ("r-svgui" ,r-svgui)))
> +    (home-page "https://github.com/SciViews/svDialogs/")
> +    (synopsis "Standard dialog boxes for Windows, MacOS and Linux")

Please use =E2=80=9CPortable dialog boxes=E2=80=9D instead.

> +    (license license:gpl2)))

This is correct.

--
Ricardo