From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: 32586@debbugs.gnu.org
Cc: pimi <madalinionel.patrasc@mdc-berlin.de>
Subject: [bug#32586] [PATCH] gnu: Add r-svdialogs.
Date: Mon, 3 Sep 2018 17:32:50 +0200 [thread overview]
Message-ID: <idjmusy38bh.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <20180830102502.10156-1-madalinionel.patrascu@mdc-berlin.de>
Hi,
thanks for the patch!
> +
> +(define-public r-svdialogs
> + (package
> + (name "r-svdialogs")
> + (version "1.0.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "svDialogs" version))
> + (sha256
> + (base32 "0xqppydfawnwk84kb5qiybwbcmv38vn4imgz01mz2pnq4xb80p97"))))
> + (properties `((upstream-name . "svDialogs")))
> + (build-system r-build-system)
> + (inputs
> + `(("yad" ,yad)
I see that you provide a patch for “yad” in another issue. In the
future please send a series of dependent patches together to the same
ticket address. (Create a new ticket first by sending a “cover letter”
to guix-patches@gnu.org first.)
> + ("zenity" ,zenity)))
> + (propagated-inputs
> + `(("r-rstudioapi" ,r-rstudioapi)
> + ("r-svgui" ,r-svgui)))
> + (home-page "https://github.com/SciViews/svDialogs/")
> + (synopsis "Standard dialog boxes for Windows, MacOS and Linux")
Please use “Portable dialog boxes” instead.
> + (license license:gpl2)))
This is correct.
--
Ricardo
next prev parent reply other threads:[~2018-09-03 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 10:25 [bug#32586] [PATCH] gnu: Add r-svdialogs pimi
2018-09-03 15:32 ` Ricardo Wurmus [this message]
2018-09-03 15:34 ` Ricardo Wurmus
2018-09-06 15:11 ` [bug#32586] [PATCH] asasa pimi
2018-09-06 15:14 ` [bug#32586] MadalinIonel.Patrascu
2018-09-06 15:14 ` [bug#32586] [PATCH] gnu: Add r-svdialogs pimi
2018-09-06 15:18 ` [bug#32586] Previous patch is good MadalinIonel.Patrascu
2018-09-13 13:08 ` bug#32586: [PATCH] gnu: Add r-svdialogs Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjmusy38bh.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=32586@debbugs.gnu.org \
--cc=madalinionel.patrasc@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.