Re: [PATCH] openblas on MIPS.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

>> * gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=SICORTEX" to
>>   make-flags when building for MIPS.
>
> Sounds good but…
>
>> -                   '("DYNAMIC_ARCH=1")
>> -                   ;; On MIPS we force the SICORTEX TARGET, as for the other
>> -                   ;; two available MIPS targets special Loongson extended
>> -                   ;; instructions are used.
>> -                   (if (string-prefix? "mips" (%current-system))
>> -                       '("TARGET=SICORTEX")
>
> This doesn’t seem to be a patch against master, is it?

Here’s the corrected patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-openblas-Set-TARGET-to-SICORTEX-on-MIPS.patch --]
[-- Type: text/x-patch, Size: 1597 bytes --]

From 99bdf62c3ff47ad3cb3a57092ed96baa1055fa77 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 20 Jul 2015 15:05:55 +0200
Subject: [PATCH 1/2] gnu: openblas: Set TARGET to SICORTEX on MIPS.

* gnu/packages/maths.scm (openblas)[arguments]: Add "TARGET=SICORTEX" to
  make-flags when building for MIPS.
---
 gnu/packages/maths.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 4935f80..b5abc48 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1491,10 +1491,16 @@ constant parts of it.")
              ;; Unfortunately, this is not supported on non-x86 architectures,
              ;; where it leads to failed builds.
              ,@(let ((system (or (%current-target-system) (%current-system))))
-               (if (or (string-prefix? "x86_64" system)
+                 (cond
+                  ((or (string-prefix? "x86_64" system)
                        (string-prefix? "i686" system))
-                   '("DYNAMIC_ARCH=1")
-                   '())))
+                   '("DYNAMIC_ARCH=1"))
+                  ;; On MIPS we force the "SICORTEX" TARGET, as for the other
+                  ;; two available MIPS targets special extended instructions
+                  ;; for Loongson cores are used.
+                  ((string-prefix? "mips" system)
+                   '("TARGET=SICORTEX"))
+                  (else '()))))
        ;; no configure script
        #:phases (alist-delete 'configure %standard-phases)))
     (inputs
-- 
2.1.0