[PATCH] gnu: kyotocabinet (new variable)

[PATCH] gnu: kyotocabinet (new variable)

[Nils Gillmann]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

This adds kyotocabinet.
Phases all succeed, however I can't test it yet in practice as
panopticon (in progress with packaging) is the only software I
have which relies on it and I'm not a database expert.

1 sentence description due to the lack of knowledge about
kyotocabinet. If you know more, feel free to add a patch later on
to fix this.


[-- Attachment #2: 0001-gnu-Add-kyotocabinet.patch --]
[-- Type: text/x-patch, Size: 1957 bytes --]

From 598086b1c9b7c7e4adfe1cfbb00ab8f6a7e119a6 Mon Sep 17 00:00:00 2001
From: Nils Gillmann <niasterisk@grrlz.net>
Date: Fri, 19 Feb 2016 11:10:06 +0100
Subject: [PATCH] gnu: Add kyotocabinet

* gnu/packages/databases.scm (kyotocabinet): New variable.
---
 gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index b51d968..cda5fc1 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2015 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -822,3 +823,28 @@ supports many data structures including strings, hashes, lists, sets, sorted
 sets, bitmaps and hyperloglogs.")
     (home-page "http://redis.io/")
     (license bsd-3)))
+
+(define-public kyotocabinet
+  (package
+    (name "kyotocabinet")
+    (version "1.2.76")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://fallabs.com/kyotocabinet/pkg/"
+                                  name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0g6js20x7vnpq4p8ghbw3mh9wpqksya9vwhzdx6dnlf354zjsal1"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       (list
+        (string-append "LDFLAGS=-Wl,-rpath="
+                       (assoc-ref %outputs "out") "/lib"))))
+    (inputs `(("zlib" ,zlib)))
+    (home-page "http://fallabs.com/kyotocabinet/")
+    (synopsis
+     "Kyoto Cabinet is a straightforward implementation of dbm")
+    (description
+     "Kyoto Cabinet is a library of routines for managing a database.")
+    (license gpl3+)))
-- 
2.6.3


[-- Attachment #3: Type: text/plain, Size: 8 bytes --]


-- 
ng

Re: [PATCH] gnu: kyotocabinet (new variable)

[Nils Gillmann]

Nils Gillmann <niasterisk@grrlz.net> writes:

> This adds kyotocabinet.
> Phases all succeed, however I can't test it yet in practice as
> panopticon (in progress with packaging) is the only software I
> have which relies on it and I'm not a database expert.
According to website, additional post-installation tests are
include (or existing somewhere), so I revoke this patch and send
in another one, once I have enough tests in the package.
>
> 1 sentence description due to the lack of knowledge about
> kyotocabinet. If you know more, feel free to add a patch later on
> to fix this.

Anyone here who knows enough about kyotoarchives or databases and
describing them, add a longer description please. My priority is
not to use this software, it's just a dependency on the way to
get panopticon to run and I know too little about kyotoarchives
to describe it.

-- 
ng

Re: [PATCH] gnu: kyotocabinet (new variable)

[Nils Gillmann]

In addition, does somebody know if we would need a patch of
kyotocabinet like gentoo does here:

https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-db/kyotocabinet/files/kyotocabinet-1.2.76-configure-8-byte-atomics.patch?id=a2115010f6dabb5cb638743be648bea292892243

If this link was typed out wrong, search for the file.

I'm just not fluent enough in C (just started) to know if we need
this. The rest of the patches look like they are not necessary
for us.

-- 
ng

Re: [PATCH] gnu: kyotocabinet (new variable)

[Nils Gillmann]

Appended as explantion:

Please disregard the last 2 emails on this patch.

Explanatory part:
I also have almost no idea how to describe it in a better way, I
just need this as a dependency for panopticon.
From my point of view, using the patch i did send on this (with 2
additional comments) will work, somebody with more knowledge
about databases can later fix the description, because it's just
not my interest and mainly because it's not easy to find out
after looking at the website and tarball. it's a database.. I
need it for a program which relies on it. I will notice if it's
broken and file a bug report myself to work on it.
it (this patch) builds without failure and gives no error if I
don't try what I currently try to do because I was told it would
be better for databases or something along the lines, which is
letting the examples run with the build, more than just make
check on rootfolder Makefile but the ones included in
examples/ and ran by examples/Makefile.

I would look into what it actually does and how it can be
described, but right now that's not my focus and not
my level of expertise.

Like I have written in the panopticon emails, I need to work on
rust and rust cargo import. This database is a dependency of
panopticon, for me as a packager it should not be priority to
get a level of expertise good enough to see if it performs
without failure. Of course it's an optional good skill, but my
time is limited and invested in more than just trying to
understand a database I will never use myself actively and only
use it through a third programm which deals with it directly.

Any thoughts against applying this patch?



Nils Gillmann <niasterisk@grrlz.net> writes:

> This adds kyotocabinet.
> Phases all succeed, however I can't test it yet in practice as
> panopticon (in progress with packaging) is the only software I
> have which relies on it and I'm not a database expert.
>
> 1 sentence description due to the lack of knowledge about
> kyotocabinet. If you know more, feel free to add a patch later on
> to fix this.
>
> From 598086b1c9b7c7e4adfe1cfbb00ab8f6a7e119a6 Mon Sep 17 00:00:00 2001
> From: Nils Gillmann <niasterisk@grrlz.net>
> Date: Fri, 19 Feb 2016 11:10:06 +0100
> Subject: [PATCH] gnu: Add kyotocabinet
>
> * gnu/packages/databases.scm (kyotocabinet): New variable.
> ---
>  gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index b51d968..cda5fc1 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -8,6 +8,7 @@
>  ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
>  ;;; Copyright © 2015 Leo Famulari <leo@famulari.name>
>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2016 Nils Gillmann <niasterisk@grrlz.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -822,3 +823,28 @@ supports many data structures including strings, hashes, lists, sets, sorted
>  sets, bitmaps and hyperloglogs.")
>      (home-page "http://redis.io/")
>      (license bsd-3)))
> +
> +(define-public kyotocabinet
> +  (package
> +    (name "kyotocabinet")
> +    (version "1.2.76")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://fallabs.com/kyotocabinet/pkg/"
> +                                  name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0g6js20x7vnpq4p8ghbw3mh9wpqksya9vwhzdx6dnlf354zjsal1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list
> +        (string-append "LDFLAGS=-Wl,-rpath="
> +                       (assoc-ref %outputs "out") "/lib"))))
> +    (inputs `(("zlib" ,zlib)))
> +    (home-page "http://fallabs.com/kyotocabinet/")
> +    (synopsis
> +     "Kyoto Cabinet is a straightforward implementation of dbm")
> +    (description
> +     "Kyoto Cabinet is a library of routines for managing a database.")
> +    (license gpl3+)))
> -- 
> 2.6.3

-- 

ng

irc://loupsycedyglgamf.onion:67/~NiAsterisk
http://loupsycedyglgamf.onion/NiAsterisk/
torify telnet loupsycedyglgamf.onion

Re: [PATCH] gnu: kyotocabinet (new variable)

[Ricardo Wurmus]

Nils Gillmann <niasterisk@grrlz.net> writes:

> Appended as explantion:
>
> Please disregard the last 2 emails on this patch.
>
> Explanatory part:
> I also have almost no idea how to describe it in a better way, I
> just need this as a dependency for panopticon.
> From my point of view, using the patch i did send on this (with 2
> additional comments) will work, somebody with more knowledge
> about databases can later fix the description, because it's just
> not my interest and mainly because it's not easy to find out
> after looking at the website and tarball. it's a database..

Actually, the website contains a workable description under “Overview”:

    Kyoto Cabinet is a library of routines for managing a database. The
    database is a simple data file containing records, each is a pair of
    a key and a value. Every key and value is serial bytes with variable
    length. Both binary data and character string can be used as a key
    and a value. Each key must be unique within a database. There is
    neither concept of data tables nor data types. Records are organized
    in hash table or B+ tree.

I see that your description is just the first sentence of this
explanation:

    Kyoto Cabinet is a library of routines for managing a database.

I think something like this would be sufficient:

    Kyoto Cabinet is a library of routines for managing a database.  The
    database is a simple data file containing key value pairs.  Both
    binary data and character string can be used for keys and values.
    Records are organized in a hash table or B+ tree.

What do you think?

~~ Ricardo