From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add python-tables.
Date: Mon, 13 Jun 2016 17:02:38 +0200
Message-ID: <idjk2htxhbl.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjshyf7zgl.fsf@bimsb-sys02.mdc-berlin.net>
	<20160424191242.GB9128@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bCTPW-00006p-ER
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:04:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bCTPT-0005wW-6q
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:04:18 -0400
Received: from sinope02.bbbm.mdc-berlin.de ([141.80.25.24]:60425)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bCTPS-0005vl-Sd
	for guix-devel@gnu.org; Mon, 13 Jun 2016 11:04:15 -0400
In-Reply-To: <20160424191242.GB9128@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>


Leo Famulari <leo@famulari.name> writes:

> On Thu, Apr 21, 2016 at 05:28:58PM +0200, Ricardo Wurmus wrote:
>> Subject: [PATCH] gnu: Add python-tables.
>  =20
>> +    (arguments
>> +     `(#:configure-flags
>> +       (list (string-append "--hdf5=3D"
>> +                            (assoc-ref %build-inputs "hdf5")))
>> +       ;; FIXME: python-build-system does not pass configure-flags to=
 "build"
>> +       ;; or "check", so we must override the build and check phases.
>
> Does setting #:configure-flags have any effect at all?

No, unfortunately, it does not.  I think we should improve the
python-build-system here.

Thanks for the review!  I=E2=80=99ll push it after removing the configure=
-flags
and addressing Ben=E2=80=99s question.

~~ Ricardo