From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add cereal + sparsehash
Date: Mon, 30 Nov 2015 14:44:18 +0100
Message-ID: <idjio4ja9fx.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjvb8oapmi.fsf@bimsb-sys02.mdc-berlin.net>
	<87poyut9jk.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60103)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a3Okp-0008WF-0z
	for guix-devel@gnu.org; Mon, 30 Nov 2015 08:44:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a3Okl-0006QM-1g
	for guix-devel@gnu.org; Mon, 30 Nov 2015 08:44:30 -0500
In-Reply-To: <87poyut9jk.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

>> From 19a28042f3839ea23aa13f4973172ca46cfde5f0 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Mon, 9 Nov 2015 14:46:56 +0100
>> Subject: [PATCH 1/2] gnu: Add cereal.
>>
>> * gnu/packages/serialization.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> [...]
>
>> +         (replace 'install
>> +          (lambda* (#:key outputs #:allow-other-keys)
>> +            (let* ((out     (assoc-ref outputs "out"))
>> +                   (doc     (string-append out "/share/cereal/docs"))
>> +                   (include (string-append out "/include/cereal")))
>> +              (mkdir-p doc)
>> +              (mkdir-p include)
>> +              (copy-recursively "include/cereal" include)
>> +              (copy-recursively "doc/html" doc))
>
> Maybe add a comment about why =E2=80=9Cmake install=E2=80=9D isn=E2=80=99=
t enough.

Okay.  I added a comment explaining that there is no =E2=80=9Cinstall=E2=80=
=9D target.

> Otherwise LGTM.
>
>> From 1f8739407dd3f9715005d55befabf894fa98ee10 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Tue, 10 Nov 2015 15:41:04 +0100
>> Subject: [PATCH 2/2] gnu: Add sparsehash.
>>
>> * gnu/packages/crypto.scm (sparsehash): New variable.
>
> LGTM.

Thank you.  I=E2=80=99ll push both in a moment.

~~ Ricardo