From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add aragorn. Date: Tue, 21 Jul 2015 15:40:35 +0200 Message-ID: References: <55AE4599.5040601@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHXmx-0002uA-KQ for guix-devel@gnu.org; Tue, 21 Jul 2015 09:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHXmu-0002Ca-Dl for guix-devel@gnu.org; Tue, 21 Jul 2015 09:40:55 -0400 Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:51937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHXmu-0002C3-1H for guix-devel@gnu.org; Tue, 21 Jul 2015 09:40:52 -0400 In-Reply-To: <55AE4599.5040601@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ben Woodcroft Cc: "guix-devel@gnu.org" Ben Woodcroft writes: > +(define-public aragorn > + (package > + (name "aragorn") > + (version "1.2.36") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "http://mbio-serv2.mbioekol.lu.se/ARAGORN/Download= s/aragorn" > + version ".tgz")) > + (file-name (string-append name "-" version ".tgz")) Is this really necessary? The version is included in the tarball name, it just doesn=E2=80=99t look like =E2=80=9Cname-version.tgz=E2=80=9D but = like =E2=80=9Cnameversion.tgz=E2=80=9D. I think it could be left off. > + (sha256 > + (base32 > + "1dg7jlz1qpqy88igjxd6ncs11ccsirb36qv1z01a0np4i4jh61mb"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; there are no tests > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'build > + (lambda _ > + (zero? (system* "gcc" > + "-O3" > + "-ffast-math" > + "-finline-functions" > + "-o" > + "aragorn" > + (string-append > + "aragorn" ,version ".c"))))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append > + (assoc-ref outputs "out") "/bin")) > + (man (string-append > + (assoc-ref outputs "out") "/share/man/m= an1"))) > + (mkdir-p bin) > + (copy-file "aragorn" > + (string-append bin "/aragorn")) > + (mkdir-p man) > + (copy-file "aragorn.1" > + (string-append man "/aragorn.1"))) > + #t))))) > + (home-page "http://mbio-serv2.mbioekol.lu.se/ARAGORN") > + (synopsis > + "Detect tRNA, mtRNA and tmRNA genes in nucleotide sequences") > + (description > + "Aragorn identifies transfer RNA and transfer-messenger RNA seque= nces from > +nucleotide sequences, based on homology to known tRNA consensus sequen= ces and > +RNA structure. It output the secondary structure of the predicted RNA.= ") There is a space missing at the end of the sentence. Double-spacing should be used. > + (license license:gpl2))) > + Other than that it looks fine to me! Thanks! ~~ Ricardo