From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add aragorn.
Date: Tue, 21 Jul 2015 15:40:35 +0200 [thread overview]
Message-ID: <idjh9ox39yk.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <55AE4599.5040601@uq.edu.au>
Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
> +(define-public aragorn
> + (package
> + (name "aragorn")
> + (version "1.2.36")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://mbio-serv2.mbioekol.lu.se/ARAGORN/Downloads/aragorn"
> + version ".tgz"))
> + (file-name (string-append name "-" version ".tgz"))
Is this really necessary? The version is included in the tarball name,
it just doesn’t look like “name-version.tgz” but like
“nameversion.tgz”. I think it could be left off.
> + (sha256
> + (base32
> + "1dg7jlz1qpqy88igjxd6ncs11ccsirb36qv1z01a0np4i4jh61mb"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; there are no tests
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'build
> + (lambda _
> + (zero? (system* "gcc"
> + "-O3"
> + "-ffast-math"
> + "-finline-functions"
> + "-o"
> + "aragorn"
> + (string-append
> + "aragorn" ,version ".c")))))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append
> + (assoc-ref outputs "out") "/bin"))
> + (man (string-append
> + (assoc-ref outputs "out") "/share/man/man1")))
> + (mkdir-p bin)
> + (copy-file "aragorn"
> + (string-append bin "/aragorn"))
> + (mkdir-p man)
> + (copy-file "aragorn.1"
> + (string-append man "/aragorn.1")))
> + #t)))))
> + (home-page "http://mbio-serv2.mbioekol.lu.se/ARAGORN")
> + (synopsis
> + "Detect tRNA, mtRNA and tmRNA genes in nucleotide sequences")
> + (description
> + "Aragorn identifies transfer RNA and transfer-messenger RNA sequences from
> +nucleotide sequences, based on homology to known tRNA consensus sequences and
> +RNA structure. It output the secondary structure of the predicted RNA.")
There is a space missing at the end of the sentence. Double-spacing
should be used.
> + (license license:gpl2)))
> +
Other than that it looks fine to me! Thanks!
~~ Ricardo
next prev parent reply other threads:[~2015-07-21 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 13:14 [PATCH] Add aragorn Ben Woodcroft
2015-07-21 13:40 ` Ricardo Wurmus [this message]
2015-07-21 13:55 ` Ben Woodcroft
2015-07-21 13:57 ` Ricardo Wurmus
2015-07-21 14:01 ` Thompson, David
2015-07-21 14:42 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjh9ox39yk.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.