From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add multiqc.
Date: Tue, 5 Jul 2016 16:04:46 +0200
Message-ID: <idjh9c4uqo1.fsf@bimsb-sys02.mdc-berlin.net>
References: <20160628145042.25341-1-ricardo.wurmus@mdc-berlin.de>
	<idj7fd9wee7.fsf@bimsb-sys02.mdc-berlin.net>
	<5773029E.1000400@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bKQyD-00082e-Rr
	for guix-devel@gnu.org; Tue, 05 Jul 2016 10:05:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bKQy7-0007Kk-Rk
	for guix-devel@gnu.org; Tue, 05 Jul 2016 10:05:00 -0400
Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:55885)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1bKQy7-0007KP-Ho
	for guix-devel@gnu.org; Tue, 05 Jul 2016 10:04:55 -0400
In-Reply-To: <5773029E.1000400@uq.edu.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel@gnu.org


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> On 29/06/16 00:56, Ricardo Wurmus wrote:
>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>
>>> * gnu/packages/bioinformatics.scm (multiqc): New variable.
>>> ---
>>>   gnu/packages/bioinformatics.scm | 30 ++++++++++++++++++++++++++++++
>>>   1 file changed, 30 insertions(+)
>>>
>>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinform=
atics.scm
>>> index 04ed769..45595d0 100644
>>> --- a/gnu/packages/bioinformatics.scm
>>> +++ b/gnu/packages/bioinformatics.scm
>>> @@ -5321,3 +5321,33 @@ group or two ChIP groups run under different c=
onditions.")
>>>         (description "This program compares version strings.  It inte=
nds to be a
>>>   replacement for strverscmp.")
>>>         (license license:gpl3+))))
>>> +
>>> +(define-public multiqc
>>> +  (package
>>> +    (name "multiqc")
>>> +    (version "0.6")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append
>>> +             "https://pypi.python.org/packages/23/d9/95a5e62eea95f22=
0007d7a6683d0da1ee1d9f99e6932bcff793b6601ef15/multiqc-"
>>> +             version ".tar.gz"))
>
> I think 'pypi-uri' would be better here, now that it handles these kind=
s=20
> of URLs. We should change 'import' so that these long URLs are not prin=
ted.

Oh, I missed that update to =E2=80=9Cpypi-uri=E2=80=9D.  I=E2=80=99ll pus=
h with this change.
Thanks!

~~ Ricardo