From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add aragorn. Date: Tue, 21 Jul 2015 16:42:09 +0200 Message-ID: References: <55AE4599.5040601@uq.edu.au> <55AE4F3A.1050903@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHYkR-0000q5-FU for guix-devel@gnu.org; Tue, 21 Jul 2015 10:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHYkM-0003qc-Cx for guix-devel@gnu.org; Tue, 21 Jul 2015 10:42:23 -0400 Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:53008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHYkM-0003p3-2U for guix-devel@gnu.org; Tue, 21 Jul 2015 10:42:18 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: "guix-devel@gnu.org" Thompson, David writes: > On Tue, Jul 21, 2015 at 9:57 AM, Ricardo Wurmus > wrote: >> Something=E2=80=99s wrong with the alignment of the =E2=80=98(replace = 'install ...)=E2=80=99. >> If there are no objections I can fix the alignment and push without >> requesting another version of the patch. >> >> But I think I better wait for other comments. > > Looks fine to me, sans the alignment. One additional nitpick is the > 'string-append' calls. The newlines should happen *after* the first > argument, not before. I fixed the alignment and made a couple of small modifications to prettify the =E2=80=98string-append=E2=80=99 calls. Pushed as 8dc797f. Thanks again! ~~ Ricardo