From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add cppcheck.
Date: Wed, 2 Mar 2016 15:30:31 +0100
Message-ID: <idjegbtymt4.fsf@bimsb-sys02.mdc-berlin.net>
References: <87ziuhvz5e.fsf@gnu.org>
	<idjfuw9ype7.fsf@bimsb-sys02.mdc-berlin.net>
	<87y4a1vvpv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ab7nZ-0001Ep-Rh
	for guix-devel@gnu.org; Wed, 02 Mar 2016 09:30:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ab7nU-0003w7-59
	for guix-devel@gnu.org; Wed, 02 Mar 2016 09:30:45 -0500
In-Reply-To: <87y4a1vvpv.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Roel Janssen <roel@gnu.org> writes:

> Hello Ricardo,
>
> Thank you for your quick review.
>
>> thank you, this looks good.  I would add one sentence to the descripti=
on
>> to start with what Cppcheck is, rather than what it is not.
>>
>>    Cppcheck is a static code analyzer for C and C++.  Unlike C/C++ ...
>>
>> If that=E2=80=99s okay I=E2=80=99ll push it with this change and with =
a copyright line
>> for you.
>
> I've attached a patch with these changes.
>
> I noticed that the other packages in check.scm don't use the license: p=
refix,
> so I also left that out.

Thanks, I missed the problem with the prefix.
Just pushed it.

~~ Ricardo