From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configure'. Date: Tue, 24 May 2016 14:14:33 +0200 Message-ID: References: <1463872621-17738-1-git-send-email-donttrustben@gmail.com> <1463872621-17738-2-git-send-email-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5BEW-00076C-DX for guix-devel@gnu.org; Tue, 24 May 2016 08:14:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5BER-0008MG-9t for guix-devel@gnu.org; Tue, 24 May 2016 08:14:48 -0400 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:37538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5BEQ-0008Lk-Vb for guix-devel@gnu.org; Tue, 24 May 2016 08:14:43 -0400 In-Reply-To: <1463872621-17738-2-git-send-email-donttrustben@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org Hi Ben, I=E2=80=99m in favour of this change. I agree with Dave that the name of= this phase should not be =E2=80=9Cconfigure=E2=80=9D. > * guix/build/ruby-build-system.scm [build]: Move extraction from here .= .. > [configure]: ... to here. New variable. > [first-gemspec]: New variable. > [standard-phases]: Add 'configure'. I think these should be round parentheses. Also =E2=80=9Cstandard-phases= =E2=80=9D should really be =E2=80=9C%standard-phases=E2=80=9D. ~~ Ricardo