From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Various samtools patches.
Date: Mon, 4 May 2015 10:30:32 +0200 [thread overview]
Message-ID: <idjbni0eod3.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87k2wp311k.fsf@gnu.org>
Ludovic Courtès writes:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> The third patch adds the most recent version of the 0.1 line of
>> samtools. The input and output formats differ greatly from that used
>> and produced by samtools 1.x (which has already been packaged as
>> "samtools") and is still used in many bioinformatics pipelines.
>
> Could you write it as a comment just below (define samtools-0.1 ?
> That way people will know why it matters to keep both.
Done.
> Also, if both versions can be parallel-installed, it may be nice to give
> them a different ‘name’ field (say ‘sametools0’ for the older one.) If
> they’re not, it’s fine this way.
Unfortunately, they cannot both be installed in parallel into the same
profile as they both provide ./bin/samtools and an unversioned libbam.a.
> Otherwise all 3 patches LGTM!
Thank you for the review!
I just pushed them with the above-mentioned change.
~~ Ricardo
prev parent reply other threads:[~2015-05-04 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:35 [PATCH] Various samtools patches Ricardo Wurmus
2015-05-03 19:37 ` Ludovic Courtès
2015-05-04 8:30 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjbni0eod3.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.