all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Update mafft to 7.245.
Date: Thu, 17 Dec 2015 13:47:53 +0100	[thread overview]
Message-ID: <idja8p96y2u.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <567001F0.7060206@uq.edu.au>


Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

>> What do you think?
> I think you are quite valiant. As I say, I cannot be confident in my 
> testing (even those in the readme). The diff looked mostly fine by eye, 
> but there was some issues near the end which mangled things somewhat

What was mangled?

> (although maybe not the result, not sure). How's the attached? I upped 
> version too. OK?

I think this line may be problematic:

> +               (("([\"`| ])awk" _ prefix)

Is your intent really to replace “ awk” and “|awk”?  In my previous
patch I tried to more explicit by using alternatives in the group:

> +               (("(\"|`|\| )awk" _ prefix)

Was there a problem with the version above?  It does not replace “ awk”
and “|awk” but only “| awk” (in addition to the other two variants).

Other than that the patch does look fine.  If you confirm that this is
what you intended then I’ll push it as is.

Thanks!

~~ Ricardo

  reply	other threads:[~2015-12-17 12:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 12:18 Update mafft to 7.245 Ben Woodcroft
2015-11-10 13:06 ` Ricardo Wurmus
2015-11-10 13:12 ` Efraim Flashner
2015-11-10 22:22   ` Ben Woodcroft
2015-12-10 16:16     ` Ricardo Wurmus
2015-12-15 12:05       ` Ben Woodcroft
2015-12-17 12:47         ` Ricardo Wurmus [this message]
2015-12-17 20:01           ` Ben Woodcroft
2015-12-17 22:29             ` Ricardo Wurmus
2015-12-17 23:27               ` Ben Woodcroft
2015-12-21 14:17                 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idja8p96y2u.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.