From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add libBigWig.
Date: Thu, 25 Feb 2016 11:37:38 +0100
Message-ID: <idja8mp2hzh.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjio1e2i5g.fsf@bimsb-sys02.mdc-berlin.net>
	<20160225014702.GE31607@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtIt-0006TO-Cf
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:37:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtIp-0003BX-9t
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:37:51 -0500
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:39736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtIp-0003AP-0B
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:37:47 -0500
In-Reply-To: <20160225014702.GE31607@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>


Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 24, 2016 at 05:21:47PM +0100, Ricardo Wurmus wrote:
>> Hi Guix,
>>=20
>> the description is a little short.  Basically, this is a cleaner
>> reimplementation of a popular tool/library that is released under a
>> non-commercial license.  There is little more I can say about it and t=
he
>> original description just references that other tool.
>>=20
>> Any ideas how to improve this?
>
> If you think it will be clear to the intended audience, I'd say it's
> fine.

Okay.

> If "Kent's library" is well-known in the field, would it make sense to
> refer to it?

I don=E2=80=99t know.  They refer to the kentUtils, but I don=E2=80=99t r=
eally want to
mention them.  They are a grab bag with many different features (only
one of which is reading bigwig files), so I don=E2=80=99t think it would =
clarify
much.

>> +         (add-before 'install 'create-target-dirs
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (mkdir-p (string-append out "/lib"))
>> +               (mkdir-p (string-append out "/include"))
>> +               #t))))))
>
> Does it make sense to upstream this? I understand if it's not worth you=
r
> time...

Done:

  https://github.com/dpryan79/libBigWig/issues/6

A new commit has already been made but there=E2=80=99s no release with th=
at
change yet.  I=E2=80=99ll add a comment to this phase.

Thanks for taking the time to review this patch!

~~ Ricardo