Re: [PATCH] gnu: Add libBigWig.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 24, 2016 at 05:21:47PM +0100, Ricardo Wurmus wrote:
>> Hi Guix,
>> 
>> the description is a little short.  Basically, this is a cleaner
>> reimplementation of a popular tool/library that is released under a
>> non-commercial license.  There is little more I can say about it and the
>> original description just references that other tool.
>> 
>> Any ideas how to improve this?
>
> If you think it will be clear to the intended audience, I'd say it's
> fine.

Okay.

> If "Kent's library" is well-known in the field, would it make sense to
> refer to it?

I don’t know.  They refer to the kentUtils, but I don’t really want to
mention them.  They are a grab bag with many different features (only
one of which is reading bigwig files), so I don’t think it would clarify
much.

>> +         (add-before 'install 'create-target-dirs
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (mkdir-p (string-append out "/lib"))
>> +               (mkdir-p (string-append out "/include"))
>> +               #t))))))
>
> Does it make sense to upstream this? I understand if it's not worth your
> time...

Done:

  https://github.com/dpryan79/libBigWig/issues/6

A new commit has already been made but there’s no release with that
change yet.  I’ll add a comment to this phase.

Thanks for taking the time to review this patch!

~~ Ricardo