From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRH0u-0007w0-8Q for guix-patches@gnu.org; Fri, 08 Jun 2018 09:01:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRH0o-0004Kn-OB for guix-patches@gnu.org; Fri, 08 Jun 2018 09:01:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRH0o-0004Kd-Kh for guix-patches@gnu.org; Fri, 08 Jun 2018 09:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRH0o-0002KD-9e for guix-patches@gnu.org; Fri, 08 Jun 2018 09:01:02 -0400 Subject: [bug#31399] [PATCH] import: elpa: Implement recursive import. Resent-Message-ID: References: <87y3grykhx.fsf@gmail.com> <87wovs2bdq.fsf@gnu.org> <87603bc31l.fsf@mdc-berlin.de> <877enmzg6d.fsf@gnu.org> <87efhtdruj.fsf@gmail.com> <87vab26y1j.fsf@gnu.org> <87sh5xlbv6.fsf@gmail.com> From: Ricardo Wurmus In-Reply-To: <87sh5xlbv6.fsf@gmail.com> Date: Fri, 8 Jun 2018 14:59:59 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: Ricardo Wurmus , 31399@debbugs.gnu.org, 31399-done@debbugs.gnu.org Hi Oleg, >> I’d find it clearer to have a first patch that moves code from cran.scm >> to utils.scm, and a second patch containing the ELPA changes. No big >> deal though. > > OK, splitted the patch. Also removed unused srfi-41. > >> Please double-check that tests/{elpa,cran}.scm still pass, but if they >> do, I think you can go ahead and push. > > I tested both commits separately. Pushed as: > > - 74032da3a2ef3e99e89dd58701414004f5a6c061 > - ae9e5d6602544390fa5da0a87450405ebba012fd Thank you! > While I've tested, ‘test-tmp/db/’ directory was missing in my Guix Git > repository (‘test-tmp’ directory was present), tests failed until I > manually created by invoking ‘mkdir test-tmp/db’. I've tried to remove > ‘test-tmp’, invoke ‘./configure --localstatedir=/var --prefix=’ and > ‘make’, but it produced only ‘test-tmp’ directory. This seems to be a problem that was introduced with commit 7f9d184d9b688d13ce76eefabaddcfa76bdde2b5. -- Ricardo