From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 1/1] gnu: diffoscope: Update to 49.
Date: Thu, 25 Feb 2016 11:53:15 +0100
Message-ID: <idj8u292h9g.fsf@bimsb-sys02.mdc-berlin.net>
References: <cover.1456362314.git.leo@famulari.name>
	<bca1f32a20425e5a58dc16d2893d56f63c6bfb0f.1456362314.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtY2-0006CL-QZ
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:53:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtXz-0006kW-FK
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:53:30 -0500
Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:48084)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aYtXz-0006kL-6M
	for guix-devel@gnu.org; Thu, 25 Feb 2016 05:53:27 -0500
In-Reply-To: <bca1f32a20425e5a58dc16d2893d56f63c6bfb0f.1456362314.git.leo@famulari.name>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/package-management.scm (diffoscope): Update to 49.
> [source]: Use pypi-uri.
> [arguments]: Use python-3. Enable tests. Add 'dependency-on-python-magi=
c' phase
> and remove 'dependency-on-rpm' phase.
> ---
[...]
>      (inputs `(("rpm" ,rpm)                        ;for rpm-python
> -              ("python-file" ,python2-file)
> -              ("python-debian" ,python2-debian)
> -              ("python-libarchive-c" ,python2-libarchive-c)
> -              ("python-tlsh" ,python2-tlsh)
> +              ("python-file" ,python-file)
> +              ("python-debian" ,python-debian)
> +              ("python-libarchive-c" ,python-libarchive-c)
> +              ("python-tlsh" ,python-tlsh)
> =20
>                ;; Below are modules used for tests.
> -              ("python-pytest" ,python2-pytest)
> -              ("python-chardet" ,python2-chardet)))
> -    (native-inputs `(("python-setuptools" ,python2-setuptools)))
> +              ("python-pytest" ,python-pytest)
> +              ("python-chardet" ,python-chardet)))
>      (home-page "http://diffoscope.org/")
>      (synopsis "Compare files, archives, and directories in depth")
>      (description


Since you=E2=80=99re changing =E2=80=9Cinputs=E2=80=9D and =E2=80=9Cnativ=
e-inputs=E2=80=9D you should mention
these changes in the commit summary.

Otherwise looks okay to me.

~~ Ricardo