From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix: Support authentication when fetching from SVN.
Date: Wed, 6 Jul 2016 12:37:28 +0200 [thread overview]
Message-ID: <idj8txfuk5z.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87h9c9wwq0.fsf@gmail.com>
Alex Kost <alezost@gmail.com> writes:
> Ludovic Courtès (2016-07-01 00:09 +0300) wrote:
>>> --- a/guix/svn-download.scm
>>> +++ b/guix/svn-download.scm
>>> @@ -42,7 +42,9 @@
>>> svn-reference make-svn-reference
>>> svn-reference?
>>> (url svn-reference-url) ; string
>>> - (revision svn-reference-revision)) ; number
>>> + (revision svn-reference-revision) ; number
>>> + (username svn-reference-username (default #f))
>>
>> I think I’m old-school, but I would prefer ‘user-name’.
>
> I also prefer "user-name".
I changed it to “user-name” and pushed.
Thanks!
~~ Ricardo
prev parent reply other threads:[~2016-07-06 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 13:43 [PATCH] guix: Support authentication when fetching from SVN Ricardo Wurmus
2016-06-30 21:09 ` Ludovic Courtès
2016-07-01 9:09 ` Alex Kost
2016-07-06 10:37 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idj8txfuk5z.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.