all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ParDRe.
Date: Mon, 23 May 2016 11:32:56 +0200	[thread overview]
Message-ID: <idj60u5glvb.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87d1odw2ah.fsf@gnu.org>


Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> * gnu/packages/bioinformatics.scm (pardre): New variable.
>> ---
>>  gnu/packages/bioinformatics.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>>
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 787f386..e681c56 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -4111,6 +4111,47 @@ Needleman-Wunsch).")
>>      ;; Dual licensed; also includes public domain source.
>>      (license (list license:gpl3 license:bsd-2))))
>>  
>> +(define-public pardre
>> +  (package
>> +    (name "pardre")
>> +    (version "1.1.5")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "mirror://sourceforge/pardre/ParDRe-rel"
>> +                           version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0zkyjzv4s8q2h5npalhirbk17r5b1h0n2a42mh7njzlf047h9bhy"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:tests? #f ; no tests included
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (delete 'configure)
>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
>> +               (mkdir-p bin)
>> +               (install-file "ParDRe" bin)
>> +               #t))))))
>> +    (inputs
>> +     `(("openmpi" ,openmpi)
>> +       ("zlib" ,zlib)))
>> +    (synopsis "Parallel tool to remove duplicate DNA reads ")
>
> It would be nice to remove the space at the end of the synopsis.

Good catch!

>> +    (description
>> +     "ParDRe is a parallel tool to remove duplicate genetic sequence reads.
>> +Duplicate reads can be seen as identical or nearly identical sequences with
>> +some mismatches.  This tool will let the users to avoid the analysis of not
>> +necessary reads, reducing the time of subsequent procedures with the
>> +dataset (e.g., assemblies, mappings, etc.).  The tool is implemented with MPI
>> +in order to exploit the parallel capabilities of multicore clusters.  It is
>> +faster than multithreaded counterparts (end of 2015) for the same number of
>> +cores and, thanks to the message-passing technology, it can be executed on
>> +clusters.")
>
> Maybe transform:
> "This tool will let the users to avoid the analysis of not necessary
> reads, reducing the time of subsequent procedures with the dataset
> (e.g., assemblies, mappings, etc.)."
>
> into:
> "This tool lets users avoid the analysis of unnecesarry reads, reducing
> the time of subsequent procedures with the dataset (e.g., assemblies,
> mappings, etc.)."

Yes, I should change this to make this read like proper English :)
Thanks for taking a look!

~~ Ricardo

  reply	other threads:[~2016-05-23  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23  9:09 [PATCH] gnu: Add ParDRe Ricardo Wurmus
2016-05-23  9:29 ` Roel Janssen
2016-05-23  9:32   ` Ricardo Wurmus [this message]
2016-05-23 10:57     ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=idj60u5glvb.fsf@bimsb-sys02.mdc-berlin.net \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.