From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QEXxOMBjwmXpWQAAe85BDQ:P1 (envelope-from ) for ; Tue, 06 Feb 2024 17:52:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QEXxOMBjwmXpWQAAe85BDQ (envelope-from ) for ; Tue, 06 Feb 2024 17:52:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707238336; a=rsa-sha256; cv=none; b=sRNWuUazxE1SJpWfFuKNwZscL1F/q5DIWi1Faan+K2BoaR+l8DHImOZSfP9PWUgVkp4U4Q 25oIKbN6U/dZKP3L6iTx5kVN5wGXLjTue3U7LhCf5jtzXmkdtP+r2zHLpf8mP3fOibrx0I LfoVlsmZ+mV7+xk1YQLRa6UqhBjp436yB2SQNiy5SfWZ7Iq7yuSI55AmweSJfeKKeEHolF 4mO6JwUQUqyv9Vq70Vse3T0G5wmzEVjJMDNqqfYcyuCP/RtIbLAXMeR613ayRra5se6vx/ 9dG/1pgNYva4/UHtznDrVg3qo4Iud0rkOJlwl4tJXtUF/hFKY3bVMKMCwNY65g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707238336; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=eFLB1XATtcSdgVx6EIt2xdEUmS4rj4BwABLp2jSwh1s=; b=oUpLjviI5Ee3ebde3HrHcqR19HpZNRI630jANMGhuptaEAMXSpySQ2tZ3v/g2DML8M2u9l oarkQoqN9uT64MQ5feBgPRRBsw03FiPCDxxFVMzqKXGCoJ32Z+yZ1Rmo778immB0wy79ki NpGcWpNU2tiZ7kCg6uL/JhbiLohYUOtDLN/Rg5fF/rlJuayo/jzCXKDCppcY0Of08M45QM wu7NI8jYOCf/NxF5Ah8PUYAgCz3uJQBIcaPcoaOJ1JN8QUpBwaau+qmafjtdMG/th62x7l lSpA+Ejt0HhDG9fqCFFU3AuJWy829dFtfisf+aKr4SWgcPWdrX+SKZ1MzEoPWA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D17CE6BD0B for ; Tue, 6 Feb 2024 17:52:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXOfp-0001Bo-TB; Tue, 06 Feb 2024 11:51:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOfk-0001BU-EL; Tue, 06 Feb 2024 11:51:49 -0500 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOfj-0007Oa-08; Tue, 06 Feb 2024 11:51:48 -0500 Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rXOfe-00ESkA-AP; Tue, 06 Feb 2024 17:51:42 +0100 Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rXOfd-0006Xu-73; Tue, 06 Feb 2024 17:51:41 +0100 Received: by submission03.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rXOfZ-001iCA-K6; Tue, 06 Feb 2024 17:51:37 +0100 Date: Tue, 6 Feb 2024 16:51:36 +0000 From: Steve George To: Suhail Cc: Felix Lechner , =?utf-8?Q?Cl=C3=A9ment?= Lassieur , Guix-devel mailing list , Help-Guix mailing list Subject: Re: Guix Days: Patch flow discussion Message-ID: References: <87o7cuwxq5.fsf@> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87o7cuwxq5.fsf@> Received-SPF: permerror client-ip=2a0c:5a00:149::26; envelope-from=steve@futurile.net; helo=mailtransmit05.runbox.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -5.49 X-Migadu-Queue-Id: D17CE6BD0B X-Migadu-Spam-Score: -5.49 X-TUID: SH7ON4SkaRv6 Hi Suhail, On 5 Feb, Suhail wrote: > Felix Lechner via writes: > > > Another is that committers should commit what they think is right > > rather than ask for revised patches. > > I could be mistaken, but I believe this does happen today at least some > of the time. Is your position that > > 1. this never happens today and thus, should happen some times when > warranted. Or that, > > 2. it happens far too rarely today, and should happen more often. Or > that, > > 3. committers should never ask for revisions? (...) Just to reply to this part, there were a variety of views on what the correct balance was between teaching someone and fixing issues so that a contributors patch was applied without them having to make further efforts. The general opinion seemed to be, that it was better to fix small issues and commit the change for new users, so they had the satisfaction of their contribution making it into the repository. One proposal was to do the 'fix', and to then reply back to the bug with a diff - showing what was done. Steve