[bug#45284] Double wrapper for protonvpn

[Ryan Prior via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Hi there! This patch updates the protonvpn-cli package to use a wrapper, so now it doesn't propagate anything.

I ran into a hitch when wrapping the program the same way it's typically done didn't work. I was getting a "bad interpreter" error from the kernel when I ran the program. Digging into it, I discovered it's because the program was double-wrapped, and the second wrapping garbled the work done by the first wrapping.

Investigating further, I determined the messiness stems from python-build-system automatically wrapping my output for me to set the PYTHONPATH. From my searching in gnu/packages/python-* sources, there isn't much explicit wrapping in python land.
So y'all know me, I decided to try the dumbest possible thing first: I wrapped the wrapper.

It works fine. But you end up with a situation like:
- invoke protonvpn
- which sets PYTHONPATH and invokes .protonvpn-real
- which sets PATH and calls ..protonvpn-real-real

Additionally, in the build output we have a "wrap" phase and then a "wrap-wrapper" phase.

So what do you think? Is my dumb solution that works thus not dumb, and we should ship it? Or is there a better way of composing wrappers so that I'm not creating this billiards game situation with the entrypoint?

Cheers,
Ryan

[-- Attachment #2: Type: text/html, Size: 1520 bytes --]