From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EMB+Bo+uxmSSXQEASxT56A (envelope-from ) for ; Sun, 30 Jul 2023 20:40:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8KF8BY+uxmRkwwAAG6o9tA (envelope-from ) for ; Sun, 30 Jul 2023 20:40:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D28C4D1C7 for ; Sun, 30 Jul 2023 20:40:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=MTnnOCja; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690742414; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=43pJx4c59f3+i4p9ukjTOARaLcZP3tCmPxvrp8ewKtk=; b=Nni8D9AZF6i6qTmMvWFpTeOnNZXuVdhwmJCqVmzzxlCev9UB2DCgpSdre17Qaz5QcRTUm3 aRv6qlyGavtwmIBojUS2f0jDDgz350BS20LwaTAqPwx/t0ofDrpe7yxgyBNkVh5ry8d9IT GNS6y8MZNW3QqSnIKd2MAgPojBa/+4HCafw52y+6BtJbTQM9FXz6w4fKa6tQfRPQ7PQARH fDK6tPZMtzNoTk5hi3Uj4MqOGBCOJKCZuEnjDLy7KUDpoUSNBjdnpf+e7nGuhMM+J0dIpi 7BP+jywj9GMLxSnxLcKZhWfArrrqdUxydrGR2qrVdXvO906xJoYqElwESwEXRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=MTnnOCja; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690742414; a=rsa-sha256; cv=none; b=Z3+N+fSY+cwg8r3LTL/BV0LJ8Nd1y3llAVvzk6SXU1c20LK4wosVZCswUj5FcSUe9j0d6m BvNmsEFo8PQ1sjnnl63GKEN8yvIf+CYihof9XC6+ogMi2eQp87wlzffsM26luXzv6EWxqs qsTwfA/XWfgrlmT7gNaXMj7MHQWYTQmwibHKlEhBs0QeGlNyTGyowRFkTuBelwwirwvXwd YGKleW4YOx0e0erGlVpIKOyheFHuD6t1Z1QTe3XTSmsAHVaXM0MU5UO2HzYOKUAqMk9OqD zpT3fnh1X5UnH2Vlyabt8+vinjhCOJA3/fQe/hYFYoWGAsc1w9FJ8IS2npFTRw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQAor-0006DO-8f; Sun, 30 Jul 2023 14:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQAoo-0006Cj-Ce for guix-patches@gnu.org; Sun, 30 Jul 2023 14:07:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQAoo-0001vy-51 for guix-patches@gnu.org; Sun, 30 Jul 2023 14:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQAon-0004uh-PI for guix-patches@gnu.org; Sun, 30 Jul 2023 14:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64957] [PATCH vREVISION] gnu: Add python-fontmake. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Jul 2023 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64957 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= Cc: 64957@debbugs.gnu.org Received: via spool by 64957-submit@debbugs.gnu.org id=B64957.169074038518846 (code B ref 64957); Sun, 30 Jul 2023 18:07:01 +0000 Received: (at 64957) by debbugs.gnu.org; 30 Jul 2023 18:06:25 +0000 Received: from localhost ([127.0.0.1]:51219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQAoD-0004tt-K5 for submit@debbugs.gnu.org; Sun, 30 Jul 2023 14:06:25 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:58124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQAoB-0004tl-GM for 64957@debbugs.gnu.org; Sun, 30 Jul 2023 14:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1690740099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=43pJx4c59f3+i4p9ukjTOARaLcZP3tCmPxvrp8ewKtk=; b=MTnnOCjaBZJkFgFGJdKKMkVAPAdvi0xWwo4IWepKsxuf7z/sPor12uAKD6W1UXoClzWM+8 +bUmC35bX/Wm1sogv1zsNtEvpNfT/F0R7U8/l/IyZr5xz/6CWynMDumWnKVJA8RgL7tasl 13yU2CjzTKecaOcHG40g3oU349bauSgZLzuXXpJly85ehxsGnG0Q68IyxEdJLkBnsdXTF/ 5p7E7bgR6L+lZ01jqjrWgjYS9mlwixYMiuqpy2VBFQ/+eUDyVYpp8/10Wt5w4sZAq6oorU l/dUDHG2g+NaHNKJxTXf4zovQlkueaGhMJrO9K3HT/m4Y7mdly09luaZrqLkGg== Date: Mon, 31 Jul 2023 02:06:00 +0800 Message-ID: <87o7jt1dh3.wl-hako@ultrarare.space> From: Hilton Chain In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: +++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -2.94 X-Migadu-Queue-Id: 2D28C4D1C7 X-Migadu-Spam-Score: -2.94 X-Migadu-Scanner: mx0.migadu.com X-TUID: g+8WUymRBqMN Hi Sergio, On Sun, 30 Jul 2023 23:45:20 +0800, Sergio Pastor P=E9rez wrote: > > * gnu/packages/fontutils.scm (python-fontmake): New variable. > --- Please adjust the commit message as well. > + (version "3.4.0") The latest version is 3.6.1, can you update the definition for it? > + (build-system python-build-system) > + (propagated-inputs (list python-attrs Please change the `propagated-inputs' field into `inputs'. It's not necessary to propagate those inputs, as python-build-system already wraps the final fontmake program to find them. > + (synopsis > + "Compile fonts from sources (UFO, Glyphs) to binary (OpenType, True= Type)") > + (description > + "Fontmake compiles fonts from various sources (.glyphs, .ufo, desig= nspace) into binaries (.otf, .ttf). You can use it to create static instanc= es and variable fonts.") There are some format issues, which could also be found by running `./pre-inst-env guix lint fontmake' in your Guix checkout, I have attatched the output below. --8<---------------cut here---------------start------------->8--- gnu/packages/fontutils.scm:535:5: fontmake@3.4.0: sentences in description = should be followed by two spaces; possible infraction at 100 gnu/packages/fontutils.scm:535:0: fontmake@3.4.0: line 535 is way too long = (171 characters) gnu/packages/fontutils.scm:531:15: fontmake@3.4.0: permanent redirect from = https://github.com/googlei18n/fontmake to https://github.com/googlefonts/fo= ntmake --8<---------------cut here---------------end--------------->8--- And... The REVISION in the `git send-email' part of the manual should be replaced with a number, for example: --8<---------------cut here---------------start------------->8--- $ git send-email --annotate -v2 \ --to=3DISSUE_NUMBER@debbugs.gnu.org -1 --8<---------------cut here---------------end--------------->8--- It's used in the [PATCH v...] part of the title. Thanks