From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kFsFN0R8amI6eQAAbAwnHQ (envelope-from ) for ; Thu, 28 Apr 2022 13:36:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OOlXNkR8amIBQQEAG6o9tA (envelope-from ) for ; Thu, 28 Apr 2022 13:36:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EA2C1288F for ; Thu, 28 Apr 2022 13:36:36 +0200 (CEST) Received: from localhost ([::1]:58518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk2Rm-0002dA-C2 for larch@yhetil.org; Thu, 28 Apr 2022 07:36:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk1pY-0000I0-4F for guix-patches@gnu.org; Thu, 28 Apr 2022 06:57:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk1pW-0003V9-Gp for guix-patches@gnu.org; Thu, 28 Apr 2022 06:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk1pW-0002UV-F8 for guix-patches@gnu.org; Thu, 28 Apr 2022 06:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Apr 2022 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54906 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54906@debbugs.gnu.org Received: via spool by 54906-submit@debbugs.gnu.org id=B54906.16511433999545 (code B ref 54906); Thu, 28 Apr 2022 10:57:02 +0000 Received: (at 54906) by debbugs.gnu.org; 28 Apr 2022 10:56:39 +0000 Received: from localhost ([127.0.0.1]:45557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1p8-0002Tt-OQ for submit@debbugs.gnu.org; Thu, 28 Apr 2022 06:56:38 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:41344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk1p5-0002Te-Hf for 54906@debbugs.gnu.org; Thu, 28 Apr 2022 06:56:37 -0400 Date: Thu, 28 Apr 2022 10:56:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1651143388; bh=S48pIrYIUWFxZ8oQCo5+snvHoqcLEh1cO7iUupX74mQ=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=i8V5OiaTvJzdRViAwFq9zCef8xYwsG7R0RZuuE96lbMdY55vmP0T9grG9A0NfXALT 6/4o34Ktm9yrK1+lyOStZLMN0OAJOEf7qFqQf62Fk7/jX08AVHD21zPAoKSkWRObtO Ijv8VYUh28XB/e7jU+tVu59H0d8otSOg51vlGXFE48AsWxVho7K7nQ0nrn978qV3Ds kaxLP9pMbkxBbaGZ1FuhNf7TZi/GaLvG8Rq28BzW+PoE6sLmCwUbDQknBiTEk0yjA5 5h3EckktuUrd8rn5NqHgI4krMjbBJc8S9KbyO/S3JFz714bzMACHnD/6FlDqMEBvXe UmXjMtSLvdN5g== From: Attila Lendvai Message-ID: In-Reply-To: References: <20220413120052.25602-1-attila@lendvai.name> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651145796; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=S48pIrYIUWFxZ8oQCo5+snvHoqcLEh1cO7iUupX74mQ=; b=M6dGWMfwqStQ4sk8D/xGTIgY9BlMXS7/luQ5negDGp/o8Gd/H9IsSssvHSsHeZqLzTrAK3 zqyQWJ/HAZf5/D45vlACiJeca09J4B7A8fqnJRIJirP8X1CBaKbi2gVxNGfA41cWqtSOTf dCYO1HcvGV20LXP+J1NTOsSqdQ4QHxvRGMIJbIQPIvc60odXO6WIrLAu69X5uQnn5X/OZB 9A1fWDGRlVJe3iAQx7WhSxtubdyUpNykgkAghvwKsZRF2NO2qDS2z7G0ZvXSd1pi3fnFuc /cSY8+v31MuOjrDq8+9YuNRe9Do0yZHiugh6u5DMNbs6ipFPVFWR643MmeWXYg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651145796; a=rsa-sha256; cv=none; b=gxIq/TpAKh48GI6WUmfzaqdLJZum+r/bv9r6NsoF5tMAUE99OCxZhBy4y0Ht9Vep552sER lsgxvlDwN7skq5uHqegmL6dVRAgozd6YsKLpmTimf+nw0Af2+j5S/2+Z2w+PI6UsC+pXCh f6FFiSxuVuCaPVEoCglxTmX5ESrzhTSZ/vFvedUYauKny/txlqJR1cL7tiiVluQTVuBwnD sB20yjJqyCIMonOUBeWKHrnZ0DQbdSEchSKB3B/P4r5rixyicbR+MAXFmDBBiWVByeTMW6 EdnlsTMPILJ+IQJDXjOW40r2kuYKleEBQpIE5RlY06DjaOER75hQ/97chVg5ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=i8V5OiaT; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=i8V5OiaT; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2EA2C1288F X-Spam-Score: 1.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: ksSBxN5IOsOV > The new WIP antioxidant-build-system (intended to replace cargo-build- > system) will not have #:skip-build?, because the new build system > actually reuses the build results off the dependents. > > Likewise, maybe long-term someone will figure out how to do something > similar for go -- e.g., > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32919#5 mentions a = =E2=80=98go > build cache=E2=80=99. > > So it seems more of a work-around than a feature to me. i lack here the necessary resolution from the bird's eye view perspective, so let me describe the actual ache that i'm trying to resolve with this: currently, the GO-BUILD-SYSTEM does not reuse build artifacts of the dependencies, only includes them as source. in the current setup, i.e. without SKIP-BUILD?, if i want to import an app with 100+ dependencies, then i need to make sure that all those 100+ dependencies build fine by themselves. this is substantially more work. if there is SKIP-BUILD?, then i can just set it to false in the importer for all the dependencies, and only flip it to true for the leaf packages that i'm actualy trying to build. it seems to me that i should just remove the SKIP-BUILD? assumption from the go importer for now, and file my commits against vanilla master. i'll proceed with that. thanks for the feedback! -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CPeople do not seem to realize that their opinion of the world is a= lso a confession of character.=E2=80=9D =09=E2=80=94 Ralph Waldo Emerson (1803=E2=80=931882)