From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mHnNJT/mgWD2bwEAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 23:10:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QHV5IT/mgWB/HQAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 21:10:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29A1C1AE62 for ; Thu, 22 Apr 2021 23:10:23 +0200 (CEST) Received: from localhost ([::1]:60830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZgac-0003RX-CN for larch@yhetil.org; Thu, 22 Apr 2021 17:10:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgaN-0003Pe-F3 for guix-devel@gnu.org; Thu, 22 Apr 2021 17:10:07 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZgaI-0008Nw-KE for guix-devel@gnu.org; Thu, 22 Apr 2021 17:10:06 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FR96W4Snxz1DDYw; Thu, 22 Apr 2021 23:09:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FR96W4Snxz1DDYw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1619125796; bh=wWTp6Dr4FQH1jXtf2NVxhGDaU9y+oge8O04Lre0YtgY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=hk5t/qPP5vaNdgx36cFNr9KzASkdX/KfCQMiV/SlW8Cxgp2kVguSeaKR/UNFEMYgR CKqZHTgbT3a+W1KSz+kLS4ybprpF6MZ0pPDoWWsDpn7arvKqDT1ih1E61VskOK6d7z vsMv0/wM0NPX2QlOZVqXSdDWXDSMAVr7c/GkyXlc= Message-ID: Subject: Re: A "cosmetic changes" commit that removes security fixes From: Leo Prikler To: =?ISO-8859-1?Q?L=E9o?= Le Bouter , Mark H Weaver , Raghav Gururajan , Guix Devel Date: Thu, 22 Apr 2021 23:09:54 +0200 In-Reply-To: References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619125823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wWTp6Dr4FQH1jXtf2NVxhGDaU9y+oge8O04Lre0YtgY=; b=tM7VLD7ZAFQARxy64zUNM1FHppRx1SDHBJk4CKYAJaOZc9RfVSnzQ4c5xrGMpe3aEDXhC0 UK+Z34ca+E7k+JkiWdq+38vSVoXS1H9wpT5vQlcV2iOE/RvU608WBpEeEiIENPPJR1QC21 q0H9up+emzrdJbB2owTxBZQgWgorL9lBEwf5DhSE9NtcLIN1heElg/n6wpAEjPeI0QWJEp ECiM2KcB/ejSwRZSy9bMxlb6OU09LHcPb4NS11yBgBWCk73rCt73lg2RQ+xzz3tOYzTIpk O/DY2tCYNasI0wwToho0/1v6SNfteMcbXEfeZc1qkfMjRJIuZCT69TlaFZha9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619125823; a=rsa-sha256; cv=none; b=A9vEhYUJVIaNVJebYggfS64X4q2ErAN20FwhvgO3yz2YePGdFfD83AfWL19FGZ/uKL5MBD lArOOB6lAuO3HLqy/35efwyrVqauV9LzZ+OzL227xU3+8NGaYbS54/tJFuq7G19aa1tKXa GhfTuneHaYwB+3fL34otym+z3tQUf+tIJPexPAXTkFGtXkKfa1Vf5oYQC30ZTEDWesEMFA Bh73p2X9UQ/r5+kpUoHsH1I7dZNuKhtJE/hF9uxHutK8O54QBAaL6CnlEyFDXkkcu1KOf4 eIC40uA1ciM7XEJOJdbavDM0jxZLdVdJawNy/3ySNoNdfk8+TtCW3CPAgbukug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="hk5t/qPP"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="hk5t/qPP"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 29A1C1AE62 X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: bkzFa+mIJM0O Am Donnerstag, den 22.04.2021, 22:01 +0200 schrieb Léo Le Bouter: > On Thu, 2021-04-22 at 00:08 -0400, Mark H Weaver wrote: > > Hi Raghav, > > > > Raghav Gururajan writes: > > > > > > Those commits on 'core-updates' were digitally signed by Léo Le > > > > Bouter > > > > and have the same problems: they remove > > > > security > > > > fixes, and yet the summary lines indicate that only "cosmetic > > > > changes" > > > > were made. > > > > > > Yeah, the commit title didn't mention the change but the commit > > > message did. > > > > I'm sorry, but that won't do. There are at least three things > > wrong > > with these commits: > > > > (1) The summary lines were misleading, because they implied that no > > functional changes were made. > > > > (2) The commit messages were misleading, because they failed to > > mention > > that security holes which had previously been fixed were now > > being > > re-introduced. That wasn't at all obvious. > > > > Commits like these, which remove patches that had fixed > > security > > flaws, are fairly common: someone casually looking over the > > commit > > log might assume that the patches could be safely removed > > because > > a > > version update was done at the same time, rendering those > > patches > > obsolete. > > > > (3) Although your 'glib' commit was immediately followed by a > > 'glib' > > update, rendering it harmless, your misleading 'cairo' commit > > left > > 'cairo' vulnerable to CVE-2018-19876 and CVE-2020-35492 on our > > 'core-updates' and 'wip-gnome' branches. Those will need to be > > fixed now. > > > > Léo Le Bouter is also culpable here, because > > he > > digitally signed the misleading 'cairo' commit that's on our > > 'core-updates' branch, which re-introduced CVE-2018-19876 and > > CVE-2020-35492. > > > > --8<---------------cut here---------------start------------->8--- > > commit f94cdc86f644984ca83164d40b17e7eed6e22091 > > gpg: Signature made Fri 26 Mar 2021 05:13:57 PM EDT > > gpg: using RSA key > > 148BCB8BD80BFB16B1DE0E9145A8B1E86BCD10A6 > > gpg: Good signature from "Léo Le Bouter " > > [unknown] > > gpg: WARNING: This key is not certified with a trusted signature! > > gpg: There is no indication that the signature belongs to > > the owner. > > Primary key fingerprint: 148B CB8B D80B FB16 B1DE 0E91 45A8 B1E8 > > 6BCD 10A6 > > Author: Raghav Gururajan > > Date: Fri Dec 4 00:48:43 2020 -0500 > > > > gnu: cairo: Make some cosmetic changes. > > > > * gnu/packages/patches/cairo-CVE-2018-19876.patch, > > gnu/packages/patches/cairo-CVE-2020-35492.patch: Remove > > patches. > > * gnu/local.mk (dist_patch_DATA): Unregister them. > > * gnu/packages/gtk.scm (cairo): Make some cosmetic changes. > > [replacement]: Remove. > > (cairo/fixed): Remove. > > > > Signed-off-by: Léo Le Bouter > > --8<---------------cut here---------------end--------------->8--- > > > > https://git.sv.gnu.org/cgit/guix.git/commit/?h=core-updates&id=f94cdc86f644984ca83164d40b17e7eed6e22091 > > > > Even the most superficial skimming of this commit should have > > immediately raised red flags, because the summary line is clearly > > inaccurate. It shows a lack of careful review, to put it mildly. > > > > Mark > > Hello Mark, > > I don't share your analysis, the security fixes werent stripped > because > glib/cairo was also updated to latest version in subsequent commits > which were pushed all at once. This may be the case for glib, but which commit pushes cairo to a version, in which those security fixes are applied?