From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IAh2EdzPK2JjMwAAgWs5BA (envelope-from ) for ; Fri, 11 Mar 2022 23:40:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KCfPDtzPK2JSuAAA9RJhRA (envelope-from ) for ; Fri, 11 Mar 2022 23:40:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E351C33B6E for ; Fri, 11 Mar 2022 23:40:27 +0100 (CET) Received: from localhost ([::1]:54490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSnvu-0001gd-VW for larch@yhetil.org; Fri, 11 Mar 2022 17:40:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnvW-0001gQ-F3 for guix-patches@gnu.org; Fri, 11 Mar 2022 17:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSnvW-0002ya-5x for guix-patches@gnu.org; Fri, 11 Mar 2022 17:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSnvW-0007vH-1m for guix-patches@gnu.org; Fri, 11 Mar 2022 17:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54260 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: 54260@debbugs.gnu.org Received: via spool by 54260-submit@debbugs.gnu.org id=B54260.164703836530406 (code B ref 54260); Fri, 11 Mar 2022 22:40:01 +0000 Received: (at 54260) by debbugs.gnu.org; 11 Mar 2022 22:39:25 +0000 Received: from localhost ([127.0.0.1]:38637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnuv-0007uL-J7 for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:39:25 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:49830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnut-0007uD-QV for 54260@debbugs.gnu.org; Fri, 11 Mar 2022 17:39:24 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by albert.telenet-ops.be with bizsmtp id 5AfN270021ZSGwU06AfNAz; Fri, 11 Mar 2022 23:39:22 +0100 Message-ID: From: Maxime Devos Date: Fri, 11 Mar 2022 23:39:21 +0100 In-Reply-To: <87czj073qt.fsf@simonsouth.net> References: <49559efd0d392df29393ac7441b83f14c2840b21.1646484354.git.simon@simonsouth.net> <87czj073qt.fsf@simonsouth.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ZZ654GTQ3TU7wp7i655l" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647038362; bh=+lZ/qQPk6lKpBbN3M4LxnlH/oJEUeCvaMbe9WFzxtS0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZpAoAJjHZ1ZPVBRj+2Ao8d9UFmkEGrr19pQZKzH2Jm9xw5iyrxfbuVn4gE33zLMuQ wPh66r5Ftq+kY0AZfRZ13UY7ETDv2X9gFSJAJd0w7T7oUZgAJn8t9hz6Fo3Sfwnmca p1gQynIUgTBYh7ioKgIIIZ/K7hazdHViuy4xShOofPDlEVPuIQyple6chvrd+LNTzG shKysa828Lc3HWHgNMYn0SoWfdPRtZkdkleiVdv9OzA4LUgdUQQI75Aao1G8pQx+Sn poqkGe/2+sNb758HUc9/pB+CY51BIfQuR0P9y8dXuyBy1R+sU9sGrvLqybiMVB/7nB lMuZMU65n1drw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647038427; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+lZ/qQPk6lKpBbN3M4LxnlH/oJEUeCvaMbe9WFzxtS0=; b=lqB5VjCdOW07X7fg5b8m2u6coFysjbt/aHztbKRcJPbfLQ0K6mIqY6VD7Vm76KTeUu2fqU sJODO+7LJX0+jZajYFMZmf8y3vnc0QTiE7dRIob2jN95jsmbUkih725iq7dbxBywOIeD54 bDTdVbR/GW8MflMWugjfMcogQzxeF+j2/dIuRgTzycMsYnUCT4UYhAxGPSKMd10P7Iqv1G fLMInEKvozlxZCYmTketS4hsgFyNcBMFq2hNpbgZKETXGLgtykzvfVzqoeYW3YHC+JRNTk 3DFz0XI9ZTxF3Q43YHMKVtP+1L0tbnOZKAczoVl5RsVPI5f9ZItuAPoICMgkjw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647038427; a=rsa-sha256; cv=none; b=Mk5l+s9BYRoYGyojsuOSKhbN66C8mHFXc4eBegzBvQcAMwmI6o41rCG1o2O9Aq6OH2xvNL B2oKOS1P6KD9LGaFg6QsWghtOz3HfnrcZ2Sc5M9GGrpJi+A2A9cbDKZz4WaCE1e22dNbaP sKCjt1oEE9i632hwMIWXTsZ+rKwyvpZihY3IaK4cjJcy9bVmQRNmiDpitoElqVAl7/6A79 YJ5oDGTZrjkyPMAq87P2NC2UV/M9FQJq4jfXiWXOEPpzAuG/usBNmWworaNYAGlb9PtfpQ Qvc05HJEia4ays0k2Ii5/6gdhzA/Csq39GPw+J9vQjEE2fV7yU7+DBgu7ii41A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ZpAoAJjH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=ZpAoAJjH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E351C33B6E X-Spam-Score: 2.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: QTrSHP0Xv/BO --=-ZZ654GTQ3TU7wp7i655l Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Simon South schreef op za 05-03-2022 om 11:39 [-0500]: > This occurred to me, but is it not better in this case to rely on the > "output" parameter passed into the procedure?=C2=A0 Using "#$output" in t= his > context feels like a violation of the Law of Demeter, like using a > global variable where a local one would be appropriate. 'outputs' is an argument to the phase procedure, but as I understand it, it is only due to historical reasons (G-exps are relatively new- ish) and because the procedures in (guix build FOO-build-system) have no other method for determining the outputs. Might be a good idea to confirm with chief gexpologist ludo though. Greetings, Maxime. --=-ZZ654GTQ3TU7wp7i655l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivPmRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qH1AP4i0eFy+IiOgu1QeJgzlCIcFfdk LgPdzXKJUAkOYmfoJwEA8o4NMWyuhuuJ3PLlZX9K++7cOXxwyiseMNZ4SHR2uwQ= =6QAj -----END PGP SIGNATURE----- --=-ZZ654GTQ3TU7wp7i655l--