From: Maxime Devos <maximedevos@telenet.be>
To: Simon South <simon@simonsouth.net>
Cc: 54260@debbugs.gnu.org
Subject: [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases.
Date: Fri, 11 Mar 2022 23:39:21 +0100 [thread overview]
Message-ID: <ff4ffce2b1de597a4a8511b3146ccaa01a2442dd.camel@telenet.be> (raw)
In-Reply-To: <87czj073qt.fsf@simonsouth.net>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
Simon South schreef op za 05-03-2022 om 11:39 [-0500]:
> This occurred to me, but is it not better in this case to rely on the
> "output" parameter passed into the procedure? Using "#$output" in this
> context feels like a violation of the Law of Demeter, like using a
> global variable where a local one would be appropriate.
'outputs' is an argument to the phase procedure, but as I understand
it, it is only due to historical reasons (G-exps are relatively new-
ish) and because the procedures in (guix build FOO-build-system) have
no other method for determining the outputs.
Might be a good idea to confirm with chief gexpologist ludo though.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-11 22:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 12:56 [bug#54260] [PATCH 0/3] gnu: ucsim: Update to 0.7.1 Simon South
2022-03-05 12:58 ` [bug#54260] [PATCH 1/3] gnu: ucsim: Don't run tests when cross-compiling Simon South
2022-03-05 15:21 ` Maxime Devos
2022-03-05 12:59 ` [bug#54260] [PATCH 2/3] gnu: ucsim: Don't explicitly return #t from phases Simon South
2022-03-05 15:23 ` Maxime Devos
2022-03-05 16:39 ` Simon South
2022-03-11 22:39 ` Maxime Devos [this message]
2022-03-05 12:59 ` [bug#54260] [PATCH 3/3] gnu: ucsim: Update to 0.7.1 Simon South
2022-03-08 14:12 ` [bug#54260] [PATCH v2 0/2] " Simon South
2022-03-08 14:12 ` [bug#54260] [PATCH v2 1/2] gnu: ucsim: Don't explicitly return #t from phases Simon South
2022-03-08 14:12 ` [bug#54260] [PATCH v2 2/2] gnu: ucsim: Update to 0.7.1 Simon South
2022-03-08 15:52 ` [bug#54260] [PATCH v3 0/2] " Simon South
2022-03-08 15:52 ` [bug#54260] [PATCH v3 1/2] gnu: ucsim: Don't explicitly return #t from phases Simon South
2022-03-08 15:52 ` [bug#54260] [PATCH v3 2/2] gnu: ucsim: Update to 0.7.1 Simon South
2022-03-11 22:17 ` bug#54260: [PATCH 0/3] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4ffce2b1de597a4a8511b3146ccaa01a2442dd.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54260@debbugs.gnu.org \
--cc=simon@simonsouth.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.