From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXMoW-0006NM-HM for guix-patches@gnu.org; Sun, 02 Jun 2019 05:30:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXMoV-0006aa-8B for guix-patches@gnu.org; Sun, 02 Jun 2019 05:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54150) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXMoV-0006aM-52 for guix-patches@gnu.org; Sun, 02 Jun 2019 05:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXMoU-0007yU-Tx for guix-patches@gnu.org; Sun, 02 Jun 2019 05:30:02 -0400 Subject: [bug#36021] [PATCH] search-paths: 'environment-variable-definition' output for fish Resent-Message-ID: References: <20190531103630.6739-1-dfrumin@cs.ru.nl> <4c3d1d91-18ae-954f-2f0f-a979a974fb2c@cs.ru.nl> <87v9xpfo3d.fsf@gnu.org> From: Dan Frumin Message-ID: Date: Sun, 2 Jun 2019 11:29:42 +0200 MIME-Version: 1.0 In-Reply-To: <87v9xpfo3d.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36021@debbugs.gnu.org Hi Ludovic, On 01-06-19 15:10, Ludovic Courtès wrote: > Hi, > > Dan Frumin skribis: > >> Some background on this patch: >> Right now whenever I do any Guix operation that requires me to modify >> environment variables (e.g. installing a Guile library requires me to >> update $GUILE_LOAD_PATH afterwards), Guix helpful tells me what >> commands I have to run to update the variables. > > But see . :-) > I was actually oblivious to the fact that these environment variables can be set up for you automatically in a new shell -- I guess that's because both ~/.guix-profile/etc/profile and `guix package --search-paths` output everything in Bash format, so I didn't use it with Fish. >> However, those commands are currently in bash/POSIX(?) format `export >> VAR=VALUE`. I've modified the `environment-variable-definition` >> function to support the syntax for Fish shell as well. I don't know if >> this method of looking at the $SHELL variable is sound, but it works >> on my machine. > > “export VAR=VALUE” is actually Bash-specific. The POSIX way to do it > is: > > VAR=VALUE; export VAR > > Would that work with Fish? Unfortunately not. I wish they'd support more standard features. Best, Dan > > If it does, we might just as well take that route as it will also cater > to other POSIX-compatible shells. > > If not, your patch sounds like the right way. > > Thanks, > Ludo’. >