From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +JrsGye/fGW7LQEAkFu2QA (envelope-from ) for ; Fri, 15 Dec 2023 22:03:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id +MMqFCe/fGUKOAAAe85BDQ (envelope-from ) for ; Fri, 15 Dec 2023 22:03:35 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702674215; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Kn02WSwu6KBIIiNnv5LyAy8fprLGGL/OSiRpfGPTjvE=; b=U2Gbjv6xuM4GXIF4BM2Gd15vVq4I+3VSJEN/KLSUMXOuYcWQwF/MKhK3Mwy1VZL7oWtOXc 49w4nWbiREQhXjW7kvHZhcwhRfXq2PdH2Rse/EOBYOCwZWxOArXamnzonrUuCoFlJVNCEk 2AiPm7eXEARLerUora2PHM/FfHujGA54fHQ3vDPNYMeWn/0kAbo50tQpWTO052oEXYutqT RnUj9u1ggApPqulK2kyzn1/fWZFd6lrOqVEXsIQSgeHep+M4ht+z9iNxZy1A0J2lrmEte/ JeTQaE2HLOmdX3Ih9/MzRSsqofTspb/GJqvlepr6kTqF0UU0+JP1RE1oX2t1wA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702674215; a=rsa-sha256; cv=none; b=h7qNifmXg3S5SWvivHG/ge4iN8lYvEBh++xYcmE2I+8sJ0XOIqZN7BUQQoIH4NA4lHxtgm gN4FdSQHqoXLjenZ7xJVD0/9AFmm92jlK2TAiyukBNeZP+pv4uBWTOSykqa+RdJHI3g6Gx lrJaoOZBkoxbwvhnwgE38HVE6Uh0SVLHktTM1l7znj8M51eIh3XEilol3A58FmjzyRRlbj BI8QMiKDYj/6SfD24g0q1MOKTeDGJMWt69LIQry9uKaMNqpQjBivDN3s328+VB+/d3Wrjb Ntq2HKfhUxY/nMIQm0Z1MooJJWLt96CSRvdlLBGkiLlWVkNBQPOWoD3rnGYUwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E6285EDD4 for ; Fri, 15 Dec 2023 22:03:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEFL5-0000uh-Vd; Fri, 15 Dec 2023 16:03:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEFKq-0000re-Kk for guix-patches@gnu.org; Fri, 15 Dec 2023 16:03:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEFKp-0006NC-B4 for guix-patches@gnu.org; Fri, 15 Dec 2023 16:03:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEFKp-0003US-2j for guix-patches@gnu.org; Fri, 15 Dec 2023 16:03:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67842] [PATCH 3/4] services: mympd: Fix syslog logging and missing service destructor. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Dec 2023 21:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67842@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 67842-submit@debbugs.gnu.org id=B67842.170267417813383 (code B ref 67842); Fri, 15 Dec 2023 21:03:03 +0000 Received: (at 67842) by debbugs.gnu.org; 15 Dec 2023 21:02:58 +0000 Received: from localhost ([127.0.0.1]:53644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEFKj-0003Ti-O6 for submit@debbugs.gnu.org; Fri, 15 Dec 2023 16:02:58 -0500 Received: from smtpm2.myservices.hosting ([185.26.105.233]:44112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEFKh-0003TX-UZ for 67842@debbugs.gnu.org; Fri, 15 Dec 2023 16:02:56 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm2.myservices.hosting (Postfix) with ESMTP id 9410620E87 for <67842@debbugs.gnu.org>; Fri, 15 Dec 2023 22:02:54 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id CCD7F80098; Fri, 15 Dec 2023 22:02:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1Yf0Wc3-Lfp5; Fri, 15 Dec 2023 22:02:50 +0100 (CET) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 63B3D80067; Fri, 15 Dec 2023 22:02:50 +0100 (CET) From: Bruno Victal Date: Fri, 15 Dec 2023 21:02:38 +0000 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.66 X-Spam-Score: -4.66 X-Migadu-Queue-Id: 2E6285EDD4 X-Migadu-Scanner: mx11.migadu.com X-TUID: XCQlu1kY6I3/ * gnu/services/audio.scm: (mympd-shepherd-service): Fix syslog logging and missing service destructor. Prefer list over quasiquote. --- gnu/services/audio.scm | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm index ae991ced4d..4fcfcc13ea 100644 --- a/gnu/services/audio.scm +++ b/gnu/services/audio.scm @@ -938,14 +938,15 @@ (define (mympd-shepherd-service config) cache-directory))))) (make-forkexec-constructor - `(#$(file-append package "/bin/mympd") - "--user" #$username - #$@(if (eq? log-to 'syslog) '("--syslog") '()) - "--workdir" #$work-directory - "--cachedir" #$cache-directory) + (list #$(file-append package "/bin/mympd") + "--user" #$username + #$@(if (maybe-value-set? log-to) '() '("--syslog")) + "--workdir" #$work-directory + "--cachedir" #$cache-directory) #:environment-variables (list #$(format #f "MYMPD_LOGLEVEL=~a" log-level)) - #:log-file #$(maybe-value log-to))))))))) + #:log-file #$(maybe-value log-to)))))) + (stop #~(make-kill-destructor))))) (define (mympd-accounts config) (match-record config (user group) -- 2.41.0