From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTDqg-0007WV-QC
	for guix-patches@gnu.org; Thu, 06 Jul 2017 16:58:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTDqc-000387-DW
	for guix-patches@gnu.org; Thu, 06 Jul 2017 16:58:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:52793)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dTDqb-00037h-VT
	for guix-patches@gnu.org; Thu, 06 Jul 2017 16:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dTDqb-0005hE-Kc
	for guix-patches@gnu.org; Thu, 06 Jul 2017 16:58:01 -0400
Subject: [bug#27599] [PATCH 1/2] gnu: Add cmdtest.
Resent-Message-ID: <handler.27599.B27599.149937463721841@debbugs.gnu.org>
Message-Id: <fe25af89.AEMAMoforQcAAAAAAAAAAAPR3_IAAAACwQwAAAAAAAW9WABZXqQn@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Fri, 07 Jul 2017 02:27:04 +0530
In-reply-to: <20170706184206.11315-1-kei@openmailbox.org>
References: <87h8yp76kj.fsf@openmailbox.org>
	<20170706184206.11315-1-kei@openmailbox.org>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: 27599@debbugs.gnu.org


> +(define-public cmdtest
> +  (package
> +    (name "cmdtest")
> +    (version "0.29")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://git.liw.fi/cmdtest/snapshot/"
> +                                  name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1i6gi4yp4qqx1liax098c7nwdb24pghh11xqlrcs7lnhh079rqhb"))=
))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))

Could you try packaging the tests as well? The #:test-target should be
"check".

> +    (description
> +     "@code{cmdtest} black box tests Unix command line tools.  Roughly, =
it is
> +given a command line and input files, and the expected output, and it ve=
rifies
> +that the command line produces the expected output.  If not, it reports =
a
> +problem, and shows the differences.")

The first sentence of the description should be a full sentence.
=