all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brice Waegeneire <brice@waegenei.re>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 42193@debbugs.gnu.org
Subject: [bug#42193] [WIP 4/6] services: kernel-module-loader: Return a single 'shepherd-service'.
Date: Mon, 06 Jul 2020 10:01:59 +0000	[thread overview]
Message-ID: <fde539b184f76c2a8086f38fb77acb75@waegenei.re> (raw)
In-Reply-To: <20200706020322.3577052e@scratchpost.org>

Hello Danny,

On 2020-07-06 00:03, Danny Milosavljevic wrote:
> I mean technically we could do that, but almost none of the other
> "-shepherd-service"s we have avoid returning a list.  Why single this 
> one out?

Because I wrote that module, forgetting to add a plural to
'kernel-module-loader-shepherd-service' and when reading the dnsmasq 
service code
I was made aware of it.  It's either that patch or a stupid typo one to 
go from
'kernel-module-loader-shepherd-service' to 
'kernel-module-loader-shepherd-serviceS'.

There are currently 14 other services that are using that pattern.

> Could we change all of them to not return a list?

Maybe, but I don't see the point of doing so as I expect that if the 
procedure's
name is plural and return a list there is no need to change it.

- Brice




  reply	other threads:[~2020-07-06 10:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04 18:52 [WIP 0/6] Add kernel-module-configuration service Brice Waegeneire
2020-07-04 18:54 ` [bug#42193] [WIP 1/6] services: simulated-wifi: Use 'kernel-module-loader' Brice Waegeneire
2020-07-04 18:54 ` Brice Waegeneire
2020-07-06 11:08   ` Danny Milosavljevic
2020-07-06 12:31     ` Brice Waegeneire
2020-07-04 18:54 ` [bug#42193] [WIP 2/6] services: Add 'kernel-profile-service-type' Brice Waegeneire
2020-07-08 11:29   ` pelzflorian (Florian Pelz)
2020-07-08 16:22     ` Brice Waegeneire
2020-07-11 17:30       ` pelzflorian (Florian Pelz)
2020-07-04 18:54 ` [bug#42193] [WIP 3/6] services: Add 'modprobe-service-type' Brice Waegeneire
2020-07-04 18:54 ` [bug#42193] [WIP 4/6] services: kernel-module-loader: Return a single 'shepherd-service' Brice Waegeneire
2020-07-06  0:03   ` Danny Milosavljevic
2020-07-06 10:01     ` Brice Waegeneire [this message]
2020-07-17 18:49   ` Danny Milosavljevic
2021-01-06 18:20     ` Danny Milosavljevic
2020-07-04 18:54 ` [bug#42193] [WIP 5/6] WIP services: Add kernel-arguments-service-type Brice Waegeneire
2020-07-04 18:54 ` [bug#42193] [WIP 6/6] WIP services: Add kernel-module-configuration service Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fde539b184f76c2a8086f38fb77acb75@waegenei.re \
    --to=brice@waegenei.re \
    --cc=42193@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.